Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompose/flatten tuple inputs #18092

Merged
merged 29 commits into from
Jul 6, 2023
Merged

Decompose/flatten tuple inputs #18092

merged 29 commits into from
Jul 6, 2023

Conversation

slyalin
Copy link
Contributor

@slyalin slyalin commented Jun 15, 2023 •
edited
Loading

Decomposes (flatten) input tuples at inputs in PT FE recursively down to raw tensors.
Allow passing tuples and list as example_input argument of convert_model.

TODO: Naming of new inputs.

@slyalin slyalin added category: MO Model Optimizer do not merge category: PyTorch FE OpenVINO PyTorch Frontend labels Jun 15, 2023
@andrei-kochin andrei-kochin marked this pull request as ready for review June 23, 2023 04:48
@andrei-kochin andrei-kochin requested review from a team as code owners June 23, 2023 04:48
@andrei-kochin andrei-kochin requested a review from eaidova June 23, 2023 04:48
@slyalin slyalin requested a review from rkazants June 23, 2023 06:39
rkazants
rkazants reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in more deep review.

src/frontends/pytorch/src/transforms/prim_list_tuple_unpack_replacer.cpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/transforms/prim_list_tuple_unpack_replacer.cpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/transforms/prim_list_tuple_unpack_replacer.hpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/transforms/prim_list_tuple_unpack_replacer.cpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/transforms/prim_list_tuple_unpack_replacer.cpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/transforms/prim_list_tuple_unpack_replacer.cpp Outdated Show resolved Hide resolved
@slyalin slyalin requested a review from rkazants June 23, 2023 18:52
@slyalin slyalin marked this pull request as draft June 23, 2023 21:00
@slyalin slyalin marked this pull request as ready for review June 26, 2023 13:39
@slyalin slyalin requested a review from mvafin June 27, 2023 22:26
@github-actions github-actions bot added the category: tools OpenVINO C++ / Python tools label Jul 5, 2023
@slyalin slyalin merged commit dfba702 into openvinotoolkit:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

@eaidova eaidova eaidova approved these changes

@mvafin mvafin mvafin approved these changes

Assignees
No one assigned
Labels
category: MO Model Optimizer category: PyTorch FE OpenVINO PyTorch Frontend category: tools OpenVINO C++ / Python tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@slyalin @mvafin @eaidova @rkazants @andrei-kochin @akladiev