Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Selected format adjusts to the required input rank at get_preferred_format #18044

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[GPU] Selected format adjusts to the required input rank at get_preferred_format #18044

merged 1 commit into from
Jul 5, 2023

Conversation

kelvinchoi-intel
Copy link
Contributor

@kelvinchoi-intel kelvinchoi-intel commented Jun 14, 2023 •
edited
Loading

Details:

  • Set preferred format of gather to avoid add reorder in front of gather and reshpae
  • Prevent adding reorder:reshape_input for dynamic

Tickets:

  • 105930

@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Jun 14, 2023
@kelvinchoi-intel kelvinchoi-intel force-pushed the gather_preferred_format branch from dc496b2 to 9354348 Compare June 22, 2023 08:57
@kelvinchoi-intel kelvinchoi-intel changed the title [GPU] Set preferred format of gather to dep(0)'s output [GPU] Set preferred format of gather and reshape to avoid adding unnecessary reorder Jun 22, 2023
@kelvinchoi-intel kelvinchoi-intel force-pushed the gather_preferred_format branch from 9354348 to 798e196 Compare June 27, 2023 01:20
@kelvinchoi-intel kelvinchoi-intel changed the title [GPU] Set preferred format of gather and reshape to avoid adding unnecessary reorder [GPU] Selected format adjusts to the required input rank at get_preferred_format Jun 27, 2023
@kelvinchoi-intel kelvinchoi-intel marked this pull request as ready for review June 27, 2023 01:21
@kelvinchoi-intel kelvinchoi-intel requested review from a team as code owners June 27, 2023 01:21
@kelvinchoi-intel kelvinchoi-intel force-pushed the gather_preferred_format branch from 798e196 to 8252893 Compare June 27, 2023 01:22
@kelvinchoi-intel kelvinchoi-intel force-pushed the gather_preferred_format branch 5 times, most recently from db145a0 to afa1fc5 Compare July 5, 2023 01:59
e-ddykim
e-ddykim approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@e-ddykim e-ddykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yeonbok yeonbok merged commit 68e1f07 into openvinotoolkit:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-ddykim e-ddykim e-ddykim approved these changes

@andrew-k-park andrew-k-park andrew-k-park approved these changes

@ahnyoung-paul ahnyoung-paul ahnyoung-paul approved these changes

@yeonbok yeonbok yeonbok approved these changes

@geunhwan geunhwan Awaiting requested review from geunhwan

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kelvinchoi-intel @yeonbok @ahnyoung-paul @andrew-k-park @e-ddykim