combine test for stream_info_table #17930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void generate_stream_info(const int streams, | ||
| const std::shared_ptr<ngraph::Function>& ngraphFunc, | ||
| Config& config, | ||
| int model_perfer_init) { |
There was a problem hiding this comment.
suggest model_perfer_init change to model_prefer_init. I think this parameter can be set to default value "-1", it will not initialize the variable.
There was a problem hiding this comment.
Thanks, updated.
| std::vector<int> stream_ids; | ||
| std::string log = "[ streams info ]"; | ||
| std::vector<std::string> core_type_str = {" Any core: ", " PCore: ", " ECore: ", " Logical core: "}; | ||
| int model_perfer = -1; |
There was a problem hiding this comment.
can remove this variable initialization.
wangleis
reviewed
Jun 12, 2023
| ov::hint::PerformanceMode input_pm_hint; | ||
| ov::threading::IStreamsExecutor::ThreadBindingType input_binding_type; | ||
| std::vector<std::vector<int>> input_proc_type_table; | ||
| bool output_ht_value; |
There was a problem hiding this comment.
please add output check for core type and performance hint
wangleis
approved these changes
Jun 12, 2023
dmitry-gorokhov
approved these changes
Jun 13, 2023
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Jun 21, 2023
* combine test for stream_info_table * fix failed test cases * add check for performance hint and core type * add comments for the parameters of test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: