Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stable sort in TopK when sorting by indices #16811

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Allow stable sort in TopK when sorting by indices #16811

merged 8 commits into from
Apr 13, 2023

Conversation

tomdol
Copy link
Contributor

@tomdol tomdol commented Apr 7, 2023

Tickets:

  • 107467

@tomdol tomdol requested review from a team as code owners April 7, 2023 11:36
@tomdol tomdol requested review from tsavina and removed request for a team April 7, 2023 11:36
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: docs OpenVINO documentation labels Apr 7, 2023
mitruska
mitruska approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@mitruska mitruska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change should be followed by corresponding update/test for TopK-11 reference implementation.

@tomdol tomdol requested a review from a team as a code owner April 11, 2023 10:58
@tomdol tomdol requested a review from rkazants April 11, 2023 10:59
@github-actions github-actions bot added the category: TF FE OpenVINO TensorFlow FrontEnd label Apr 11, 2023
@tomdol
Copy link
Contributor Author

tomdol commented Apr 11, 2023

The change should be followed by corresponding update/test for TopK-11 reference implementation.

See: 108010

@tomdol tomdol requested a review from xuchen-intel April 11, 2023 11:11
@tomdol tomdol enabled auto-merge (squash) April 11, 2023 11:58
@github-actions github-actions bot removed the category: TF FE OpenVINO TensorFlow FrontEnd label Apr 11, 2023
xuchen-intel
xuchen-intel requested changes Apr 12, 2023
View reviewed changes
docs/ops/sort/TopK_11.md Outdated Show resolved Hide resolved
@tomdol tomdol disabled auto-merge April 12, 2023 06:47
@tomdol tomdol requested a review from xuchen-intel April 12, 2023 10:18
@mlukasze mlukasze merged commit dcf6fb1 into openvinotoolkit:master Apr 13, 2023
@tomdol tomdol deleted the topk_stable_indices branch April 13, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuchen-intel xuchen-intel xuchen-intel approved these changes

@PiotrKrzem PiotrKrzem PiotrKrzem approved these changes

@rkazants rkazants rkazants approved these changes

@mitruska mitruska mitruska approved these changes

@tsavina tsavina Awaiting requested review from tsavina tsavina is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: docs OpenVINO documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomdol @mitruska @rkazants @PiotrKrzem @xuchen-intel @mlukasze