Support float64 data type as input of benchmark_app #16435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-cho
requested review from
ilya-lavrenov,
ilyachur and
tomdol
and removed request for
a team
jade-cho
force-pushed
the
support_fp64_as_benchmark_app_input
branch
from
6e48ab8 to
fcf7277
Compare
jade-cho
force-pushed
the
support_fp64_as_benchmark_app_input
branch
3 times, most recently
from
01b846a to
df6b8ad
Compare
github-actions
bot
added
category: CPU
jade-cho
force-pushed
the
support_fp64_as_benchmark_app_input
branch
3 times, most recently
from
5e4c5cf to
3720eca
Compare
github-actions
bot
removed
category: CPU
ilyachur
reviewed
Mar 22, 2023
| @@ -40,6 +40,8 @@ void fill_buffer_random(void* inputBuffer, | |||
| void fill_buffer(void* inputBuffer, size_t elementsNum, const ov::element::Type& type) { | |||
| if (type == ov::element::f32) { | |||
| fill_buffer_random<float, float>(inputBuffer, elementsNum); | |||
| } else if (type == ov::element::f64) { | |||
| fill_buffer_random<double, double>(inputBuffer, elementsNum); | |||
| } else if (type == ov::element::f16) { | |||
| fill_buffer_random<short, short>(inputBuffer, elementsNum); | |||
There was a problem hiding this comment.
I think this also should be changed to:
Suggested change
| fill_buffer_random<short, short>(inputBuffer, elementsNum); | |
| fill_buffer_random<ov::float16, float>(inputBuffer, elementsNum); |
jade-cho
force-pushed
the
support_fp64_as_benchmark_app_input
branch
from
3720eca to
b12534d
Compare
isanghao
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.