[CPU] Use Dnnl executor to avoid extra dnnl primitve desc query #16372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@usstq , FIY |
usstq
reviewed
Mar 21, 2023
| const dnnl::engine& engine) { | ||
| execPrim = dnnl::convolution_forward(pd); | ||
|
|
||
| const dnnl::engine& engine) : DnnlExecutor(pd) { | ||
| if (inMemDesc != pd.src_desc()) { |
There was a problem hiding this comment.
should we change it to getSrcDesc() since pd.src_desc() is slow?
also pd.weights_desc() and pd.dst_desc() in following lines
There was a problem hiding this comment.
Good point. Changed accordingly. Thank you!
|
@dmitry-gorokhov , could you please review? |
dmitry-gorokhov
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Since v3.1 it was observed that early inefficient dnnl::primitive_desc query became even slower. It was decided to store input, output and scratchpad memory descriptors in the DnnlExecutor to avoid dnnl::primitive_desc query calls at runtime.
Tickets: