Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix strided slice kernel with begin/end/stride as inputs #16302

Merged
merged 1 commit into from
Mar 15, 2023
Merged

[GPU] Fix strided slice kernel with begin/end/stride as inputs #16302

merged 1 commit into from
Mar 15, 2023

Conversation

vladimir-paramuzov
Copy link
Contributor

Details:

  • If begin/end/stride are inputs with shape {1}, then current strided_slice impl works incorrectly as *_GET_INDEX is generated as (b % 1), thus all dimensions have the same index and offset if invalid.

@vladimir-paramuzov vladimir-paramuzov added the category: GPU OpenVINO GPU plugin label Mar 15, 2023
@vladimir-paramuzov vladimir-paramuzov added this to the 2023.0 milestone Mar 15, 2023
@vladimir-paramuzov vladimir-paramuzov requested review from a team as code owners March 15, 2023 07:46
@vladimir-paramuzov vladimir-paramuzov merged commit 28d3e10 into openvinotoolkit:master Mar 15, 2023
@vladimir-paramuzov vladimir-paramuzov deleted the strided_slice_fix branch March 15, 2023 12:25
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Mar 21, 2023
@vladimir-paramuzov @andrei-cv
[GPU] Fix strided slice kernel with begin/end/stride as inputs (openv…
71618bc 
…inotoolkit#16302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-k-park andrew-k-park andrew-k-park approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
2023.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimir-paramuzov @andrew-k-park