Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Need to exclude fused mem_dep from shape_infer_dep #16300

Conversation

kelvinchoi-intel
Copy link
Contributor

Details:

  • Fused mem_dep doesn't be considered as shape_infer_dep

Tickets:

  • 100964

@kelvinchoi-intel kelvinchoi-intel requested review from a team as code owners March 15, 2023 05:10
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Mar 15, 2023
@kelvinchoi-intel kelvinchoi-intel force-pushed the shape_infer_exclude_fused_mem_dep branch from 16f6ef0 to d0205ea Compare March 15, 2023 05:16
@kelvinchoi-intel kelvinchoi-intel changed the title [GPU] Need to exclude fused mem_dep from shape_infer_dep [Don't review][GPU] Need to exclude fused mem_dep from shape_infer_dep Mar 15, 2023
@kelvinchoi-intel kelvinchoi-intel changed the title [Don't review][GPU] Need to exclude fused mem_dep from shape_infer_dep [GPU] Need to exclude fused mem_dep from shape_infer_dep Mar 15, 2023
@yeonbok yeonbok added this to the 2023.0 milestone Mar 15, 2023
@yeonbok
Copy link
Contributor

yeonbok commented Mar 15, 2023

Please add a unittest which checks whther the fused input is being regarded as impl_param->mem_dep.

  1. Create some topology with Deconvolution (e.g, [1, 3, 2, 2] = [1,3,4,4])+ Eltwise (which has some values in second input that cannot be used as output shape of deconv, like [1, 3, 1, 1] = {1, 1, 1})
  2. Do shape infer for Deconv

@kelvinchoi-intel kelvinchoi-intel force-pushed the shape_infer_exclude_fused_mem_dep branch from d0205ea to 1884eb2 Compare March 16, 2023 07:46
@kelvinchoi-intel kelvinchoi-intel force-pushed the shape_infer_exclude_fused_mem_dep branch 2 times, most recently from 2f6fbd7 to 38ee223 Compare March 20, 2023 06:35
@kelvinchoi-intel kelvinchoi-intel force-pushed the shape_infer_exclude_fused_mem_dep branch from 38ee223 to 6c7aa81 Compare March 21, 2023 01:22
@yeonbok yeonbok merged commit 6bf2fe1 into openvinotoolkit:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants