TransposeSinking refactoring: part 2 (class names, folders, file names) #16291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: TF FE
evkotov
approved these changes
Mar 14, 2023
…arate folder, align namespaces
itikhono
changed the title
rkazants
reviewed
Mar 15, 2023
| @@ -268,7 +268,7 @@ void FrontEnd::normalize(const std::shared_ptr<ov::Model>& function) const { | |||
| manager.register_pass<ov::frontend::tensorflow_lite::pass::TFLQuantizeResolver>(); | |||
| manager.register_pass<ov::frontend::tensorflow_lite::pass::Rfft2dSimplifier>(); | |||
| manager.register_pass<ov::pass::TransposeSinking>(); | |||
| manager.register_pass<ov::pass::TransposeSinkingGeneral>(); | |||
| manager.register_pass<ov::pass::transpose_sinking::TSGeneral>(); | |||
There was a problem hiding this comment.
To me ov::pass::TransposeSinking looks better. You can include all particular TS passes into transpose_sinking namespace and remain the main entry on pass namespace.
There was a problem hiding this comment.
unfortunately, we already have ov::pass::TransposeSinking (old common transformation), see line 270
We will be able to replace it in the next Release
There was a problem hiding this comment.
I see what about TransposeSinkingExtended or TransposeSinkingAdvanced names?
There was a problem hiding this comment.
I believe we can leave both options:
ov::pass::TransposeSinkingGeneral (the alias)
ov::pass::transpose_sinking::TSGeneral
There was a problem hiding this comment.
it will be fixed in the next PR
rkazants
approved these changes
Mar 15, 2023
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Mar 21, 2023
…s) (openvinotoolkit#16291) * Add descriptions to the transformations, add additional checks * fix a warning * TransposeSinking Rafactoring part2: move the transformations to a separate folder, align namespaces * TransposeSinking refactoring: class names, namespaces * codestyle * resolve merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
All TransposeSinking transformations and tests were moved to transformations/transpose_sinking folder
Introduced ov::pass::transpose_sinking namespace
Transformation classes were renamed: TransposeSinking* -> TS*
Transformation files were renamed: transpose_sinking_* -> ts_*
before: ______________________________________________after: _______________________________
