-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU]Fix crash issue: RuntimeError: Primitive descriptor was not found for… #16186
[CPU]Fix crash issue: RuntimeError: Primitive descriptor was not found for… #16186
Conversation
Could we add a testcase to cover this? |
e8eec2e
to
151399f
Compare
Signed-off-by: Yan, Xiping <[email protected]>
Done, Adding new param for matmul single layer test. @luo-cheng2021 @dmitry-gorokhov |
Signed-off-by: Yan, Xiping <[email protected]>
@EgorDuplensky @maxnick guys, could you please take a look? |
// implType(AMX) will be not in list when input dynamic shape for AMX. | ||
// Bcause AMX will be available when it assumes batch 16 for dynamic shape in compile model. | ||
// However if we only pass batch 1 in runtime, AMX will be not available(Performance is low). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// implType(AMX) will be not in list when input dynamic shape for AMX. | |
// Bcause AMX will be available when it assumes batch 16 for dynamic shape in compile model. | |
// However if we only pass batch 1 in runtime, AMX will be not available(Performance is low). | |
// implType(AMX) may not be in the list when the input shapes are dynamic in the case of AMX. | |
// AMX is available on the compile model stage when the dummy shape is used. | |
// However, if we pass batch 1 at runtime, AMX will not be available (due to the oneDNN implementation selection algorithm). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My version would be 😄:
"In case of dynamic shapes an implementation type chosen as optimal for a primitive_desc with undefined input shapes, is not necessarily available for the primitive_desc with defined shape.
Example: brgemm_avx512_amx is available for a primitive with undefined input shapes but not available for primitive_desc with input batch 1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EgorDuplensky gave the root cause. It will be great.
Signed-off-by: Yan, Xiping <[email protected]>
Details:
Tickets: