Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ONNX Runtime from rel-1.8.1 to rel-1.14.0 #16184

Merged

Conversation

zhaixuejun1993
Copy link
Contributor

Details:

  • Update ONNX Runtime from rel-1.8.1 to rel-1.14.0

Tickets:

@ilyachur
Copy link
Contributor

Please fix:

CMake Error: Unknown argument --compile-no-warning-as-error
CMake Error: Run 'cmake --help' for all supported options.

@zhaixuejun1993
Copy link
Contributor Author

The CI filed with error: CMake Error: Unknown argument --compile-no-warning-as-error
This option ware added in PR: microsoft/onnxruntime@efcbdac#diff-a545fb992b8a8781df05a2c40541f429bfff7e0d8ecc9ef0f5d559994e187814

@ilyachur
Copy link
Contributor

ilyachur commented Mar 13, 2023

The CI filed with error: CMake Error: Unknown argument --compile-no-warning-as-error This option ware added in PR: microsoft/onnxruntime@efcbdac#diff-a545fb992b8a8781df05a2c40541f429bfff7e0d8ecc9ef0f5d559994e187814

We need to disable this option, or use CMake 3.24+ for this option. https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html

@zhaixuejun1993
Copy link
Contributor Author

The CI filed with error: CMake Error: Unknown argument --compile-no-warning-as-error This option ware added in PR: microsoft/onnxruntime@efcbdac#diff-a545fb992b8a8781df05a2c40541f429bfff7e0d8ecc9ef0f5d559994e187814

We need to disable this option, or use CMake 3.24+ for this option. https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html

Yes I also found that we need to upgtade CMake > 3.24

@riverlijunjie
Copy link
Contributor

The CI filed with error: CMake Error: Unknown argument --compile-no-warning-as-error This option ware added in PR: microsoft/onnxruntime@efcbdac#diff-a545fb992b8a8781df05a2c40541f429bfff7e0d8ecc9ef0f5d559994e187814

We need to disable this option, or use CMake 3.24+ for this option. https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html

Yes I also found that we need to upgtade CMake > 3.24

I think we should disable it for onnxruntime case, right?

@ilyachur
Copy link
Contributor

The CI filed with error: CMake Error: Unknown argument --compile-no-warning-as-error This option ware added in PR: microsoft/onnxruntime@efcbdac#diff-a545fb992b8a8781df05a2c40541f429bfff7e0d8ecc9ef0f5d559994e187814

We need to disable this option, or use CMake 3.24+ for this option. https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html

Yes I also found that we need to upgtade CMake > 3.24

I think we should disable it for onnxruntime case, right?

I think we can simpler update the CMake version

Signed-off-by: Zhai, Xuejun <[email protected]>
@zhaixuejun1993 zhaixuejun1993 requested review from a team as code owners March 13, 2023 07:05
@ilya-lavrenov
Copy link
Contributor

@ilyachur we have failed test CApiTest.test_custom_op_openvino_wrapper_library, which maybe interesting to look at from BW compatibility point of view in extensions.

@ilyachur
Copy link
Contributor

@ilyachur we have failed test CApiTest.test_custom_op_openvino_wrapper_library, which maybe interesting to look at from BW compatibility point of view in extensions.

In the test we have a difference in 0.000001 maybe here we faced with float calculation and need to understand where this issue happens.

@zhaixuejun1993
Copy link
Contributor Author

@ilyachur we have failed test CApiTest.test_custom_op_openvino_wrapper_library, which maybe interesting to look at from BW compatibility point of view in extensions.

In the test we have a difference in 0.000001 maybe here we faced with float calculation and need to understand where this issue happens.

@ilyachur @ilya-lavrenov This test is about an image classify (the input image is hand-drwn "1"), with MNIST model. test_custom_op_openvino_wrapper_library
I'm curious how the expected values were obtained expected_vals
Maybe the difference is caused by different version of OpenVINO backend, I don't know.
Anyway, how about the next step about this?

@ilyachur
Copy link
Contributor

@ilyachur we have failed test CApiTest.test_custom_op_openvino_wrapper_library, which maybe interesting to look at from BW compatibility point of view in extensions.

In the test we have a difference in 0.000001 maybe here we faced with float calculation and need to understand where this issue happens.

@ilyachur @ilya-lavrenov This test is about an image classify (the input image is hand-drwn "1"), with MNIST model. test_custom_op_openvino_wrapper_library I'm curious how the expected values were obtained expected_vals Maybe the difference is caused by different version of OpenVINO backend, I don't know. Anyway, how about the next step about this?

Did we run this test with previous ONNXRuntime version?

@zhaixuejun1993
Copy link
Contributor Author

@ilyachur we have failed test CApiTest.test_custom_op_openvino_wrapper_library, which maybe interesting to look at from BW compatibility point of view in extensions.

In the test we have a difference in 0.000001 maybe here we faced with float calculation and need to understand where this issue happens.

@ilyachur @ilya-lavrenov This test is about an image classify (the input image is hand-drwn "1"), with MNIST model. test_custom_op_openvino_wrapper_library I'm curious how the expected values were obtained expected_vals Maybe the difference is caused by different version of OpenVINO backend, I don't know. Anyway, how about the next step about this?

Did we run this test with previous ONNXRuntime version?

No this test ware added in version rel.1.14.0, no in rel-1.8.1

…ill add back with the new ONNX Runtime version

Signed-off-by: Zhai, Xuejun <[email protected]>
@ilyachur ilyachur merged commit 05866f0 into openvinotoolkit:master Mar 16, 2023
@zhaixuejun1993 zhaixuejun1993 deleted the xuejun/upgrade_onnx_runtime branch March 26, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI OpenVINO public CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants