CoreImpl small refactoring #16145
Merged
CoreImpl small refactoring #16145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: CPU
| // coreConfig.set_and_update(config); | ||
| // once GPU remove support of ov::cache_dir | ||
| // CoreConfg::set_and_update will drop CACHE_DIR from config map | ||
| // and updates core config with new ov::cache_dir |
There was a problem hiding this comment.
I supposed that ov::cache_dir will be removed from all plugin and only exist on ov::core level, it is reasonable.
If so, we also need PR to remove ov::cache_dir from meta plugin(AUTO/BATCH/HETERO)
There was a problem hiding this comment.
good point that meta plugins support cache_dir to transfer it to underlying HW plugins.
Need to think how to simplify this handling.
In general, our goal is to avoid handling of core properties by META plugins to simplify them.
ilya-lavrenov
force-pushed
the
core-refactoring
branch
from
b4d1a3c to
23eb7c3
Compare
github-actions
bot
added
category: AUTO
ilya-lavrenov
commented
Mar 8, 2023
| @@ -97,5 +97,5 @@ void ov::ICompiledModel::loaded_from_cache() { | |||
| wrapper->get_executable_network()->loadedFromCache(); | |||
| return; | |||
| } | |||
| OPENVINO_NOT_IMPLEMENTED; | |||
| // OPENVINO_NOT_IMPLEMENTED; | |||
There was a problem hiding this comment.
@ilyachur please, fix this separately
ilyachur
approved these changes
Mar 8, 2023
| // here we can store values like GPU.0, GPU.1 and we need to set properties to plugin | ||
| // for each such .0, .1, .# device to make sure plugin can handle different settings for different | ||
| // device IDs | ||
| for (auto pluginDesc : pluginRegistry) { |
There was a problem hiding this comment.
Suggested change
| for (auto pluginDesc : pluginRegistry) { | |
| for (auto&& pluginDesc : pluginRegistry) { |
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Mar 21, 2023
* Small CoreImpl refactoring * Removed cache_dirhandling from CPU plugin * clang-format * Fixed python tests * Fix * Fixed bugs in HETERO case * Fixed clang-format and warnings in auto plugin * Added import_export as capability for TEMPLATE plugin * Commented throw exception from loaded_from_cache * Fixed clang-formatof ro template plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: