[GPU] Changed impls cache key type to avoid hash collisions #16130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-paramuzov
force-pushed
the
collision_fix
branch
2 times, most recently
from
31a91ff to
0aad0cd
Compare
yeonbok
approved these changes
Mar 7, 2023
p-durandin
approved these changes
Mar 8, 2023
vladimir-paramuzov
force-pushed
the
collision_fix
branch
from
0aad0cd to
0f8af90
Compare
sshlyapn
reviewed
Mar 8, 2023
|
|
||
| struct ImplHasher { |
There was a problem hiding this comment.
Does it not make sense to make this structure a part of kernel_impl_params.hpp?
There was a problem hiding this comment.
Makes sense. Will update it in a next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
hash_combinehas high rate of hash collisions, thus updated ImplementationsCache to usekernel_impl_paramsas key instead ofsize_t(hash) and declared comparison + hash operators for impl params.Tickets: