Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Node in Model creation #15943

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Check Node in Model creation #15943

merged 2 commits into from
Feb 28, 2023

Conversation

akuporos
Copy link
Contributor

@akuporos akuporos commented Feb 24, 2023 •
edited
Loading

Details:

  • Found that check for creating Model from shared_ptr<Node> == nullptr was missed (that called when a user tries to create it in python as Model(None, []) that caused segfault)

Tickets:

  • 102965

@akuporos akuporos added the category: Core OpenVINO Core (aka ngraph) label Feb 24, 2023
@akuporos akuporos added this to the 2023.0 milestone Feb 24, 2023
@akuporos akuporos requested a review from a team as a code owner February 24, 2023 15:23
@github-actions github-actions bot added the category: CPP API OpenVINO CPP API bindings label Feb 24, 2023
@akuporos akuporos requested a review from ilyachur February 24, 2023 15:39
@akuporos akuporos added the bug Something isn't working label Feb 24, 2023
@github-actions github-actions bot removed the category: CPP API OpenVINO CPP API bindings label Feb 27, 2023
@akuporos akuporos requested a review from ilyachur February 27, 2023 12:33
@ilyachur ilyachur merged commit 45dff75 into openvinotoolkit:master Feb 28, 2023
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Mar 21, 2023
@akuporos @andrei-cv
Check Node in Model creation (openvinotoolkit#15943)
95e0052 
* Check Node in Model creation

* apply fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyachur ilyachur ilyachur approved these changes

Assignees

@ilyachur ilyachur

Labels
bug Something isn't working category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2023.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akuporos @ilyachur