Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Apivalidator to TBB libs #15938

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Apply Apivalidator to TBB libs #15938

merged 1 commit into from
Feb 28, 2023

Conversation

vurusovs
Copy link
Contributor

Tickets:

  • 89932

@vurusovs vurusovs requested a review from a team as a code owner February 24, 2023 13:46
@github-actions github-actions bot added the category: build OpenVINO cmake script / infra label Feb 24, 2023
@ilya-lavrenov ilya-lavrenov added the WIP work in progress label Feb 24, 2023
@vurusovs
Copy link
Contributor Author

In case of TBBbind::tbbbind_2_5 there is a warning IMPORTED_LOCATION not set for imported target "TBBbind::tbbbind_2_5". caused by

openvino/cmake/developer_package/api_validator/api_validator.cmake

Line 92 in 56ef377

get_target_property(target_location ${target} LOCATION)

@ilya-lavrenov ilya-lavrenov removed the WIP work in progress label Feb 25, 2023
@ilya-lavrenov ilya-lavrenov added this to the 2023.0 milestone Feb 25, 2023
@ilya-lavrenov ilya-lavrenov added the port to 2022.3 Need port from master to 2022.3 LTS label Feb 25, 2023
@vurusovs vurusovs requested review from a team as code owners February 27, 2023 11:24
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 27, 2023
@vurusovs
Copy link
Contributor Author

@ilya-lavrenov for version b2ba7a9 next libs are validated:

  • Current TBB: tbbmalloc.dll
  • oneTBB: tbbmalloc.dll, tbbbind_2_5.dll, hwloc.dll

ilya-lavrenov
ilya-lavrenov reviewed Feb 27, 2023
View reviewed changes
src/cmake/ie_parallel.cmake Outdated Show resolved Hide resolved
src/cmake/ie_parallel.cmake Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the category: CPU OpenVINO CPU plugin label Feb 28, 2023
@ilya-lavrenov ilya-lavrenov merged commit 5e48941 into openvinotoolkit:master Feb 28, 2023
@ilya-lavrenov
Copy link
Contributor

Let's port to 2022.3

@vurusovs vurusovs changed the title Apply Apivalidator to TBB and TBBBind libs Apply Apivalidator to TBB libs Feb 28, 2023
@ilya-lavrenov ilya-lavrenov removed the port to 2022.3 Need port from master to 2022.3 LTS label Feb 28, 2023
@ilya-lavrenov ilya-lavrenov mentioned this pull request Feb 28, 2023
Merged
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Mar 21, 2023
@vurusovs @andrei-cv
Apply Apivalidator to extra TBB libs (openvinotoolkit#15938)
0cad776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Assignees

@ilya-lavrenov ilya-lavrenov

@ilyachur ilyachur

Labels
category: build OpenVINO cmake script / infra
Projects
None yet
Milestone
2023.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vurusovs @ilya-lavrenov @ilyachur