Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for concatenation in Loop #15899

Merged
merged 7 commits into from
Feb 28, 2023
Merged

Add support for concatenation in Loop #15899

merged 7 commits into from
Feb 28, 2023

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Feb 22, 2023

Details:

  • Add support for concatenation in Loop

Tickets:

  • 101884

@mvafin mvafin requested a review from a team as a code owner February 22, 2023 22:15
@mvafin mvafin requested a review from eaidova February 22, 2023 22:15
@mvafin
Copy link
Contributor Author

mvafin commented Feb 22, 2023

One test will fail until #15862 is merged

@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Feb 22, 2023
@mvafin mvafin requested a review from a team as a code owner February 27, 2023 22:49
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Feb 27, 2023
itikhono
itikhono reviewed Feb 28, 2023
View reviewed changes
src/core/src/op/loop.cpp Outdated Show resolved Hide resolved
itikhono
itikhono approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@itikhono itikhono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes in Loop op look good

@mvafin mvafin merged commit 87e714e into openvinotoolkit:master Feb 28, 2023
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Mar 21, 2023
@mvafin @andrei-cv
Add support for concatenation in Loop (openvinotoolkit#15899)
586d309 
* Add support for concatenation in Loop

* Apply suggestions from code review

* Fix win build

* Fix issues with propagation shapes and types in Loop

* Fix einsum

* Set type and shape of count in frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaidova eaidova eaidova approved these changes

@itikhono itikhono itikhono approved these changes

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvafin @itikhono @eaidova