Fix tile shape inference when repeats got dynamic shape #15792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jane-intel
reviewed
Feb 24, 2023
Comment on lines
57
to
58
| const auto r = (repeats_rank.is_static() && repeats_shape[0].is_static()) ? repeats_shape[0].get_length() : 0; | ||
| output_shape.resize(std::max<size_t>(arg_rank.get_length(), r)); |
There was a problem hiding this comment.
This is incorrect behavior. Please see the specification. repeats could be longer than data rank and it will extend output rank.
There was a problem hiding this comment.
Changed to return dynamic shape.
ilyachur
approved these changes
Mar 8, 2023
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Mar 21, 2023
…kit#15792) * fix shape infer when repeats got dynamic shape * Dynamic output shape when repeats dim is dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fix tile shape calculation in case when repeats input has got dynamic shape.