Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Fix oneDNN gemm binary post-op bug #15790

Conversation

hyunback
Copy link
Contributor

@hyunback hyunback commented Feb 17, 2023

convert_gemm_tensor func's last parameter is bool variable for batched_dims_can_be_removed. 'True' condition should be batch 1 NOT multi batchs, but it was being used incorrectly.

  • bert-small-uncased-whole-word-masking-squad-int8-0002
    F1: 91.50%
    EM: 84.68%
  • bert-small-uncased-whole-word-masking-squad-0002
    F1: 91.94%
    EM: 85.44%

Tickets:

  • ticket-id

convert_gemm_tensor func's last parameter is bool variable for batched_dims_can_be_removed.
'True' condition should be batch 1 NOT multi batchs, but it was being used incorrectly.

Signed-off-by: hyunback <[email protected]>
@hyunback hyunback added the category: GPU OpenVINO GPU plugin label Feb 17, 2023
@hyunback hyunback requested review from a team as code owners February 17, 2023 12:43
Copy link
Contributor

@sshlyapn sshlyapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
@hyunback , could you please add unit test for this fix?

hyunback added a commit to hyunback/openvino that referenced this pull request Mar 3, 2023
Based on openvinotoolkit#15790 and enable onednn gemm from support multiple users and non constant input.

Signed-off-by: hyunback <[email protected]>
@hyunback hyunback closed this Mar 6, 2023
@hyunback
Copy link
Contributor Author

hyunback commented Mar 6, 2023

Replace New PR -> #16074

hyunback added a commit to hyunback/openvino that referenced this pull request Mar 7, 2023
Based on openvinotoolkit#15790 and enable onednn gemm from support multiple users and non constant input.

Signed-off-by: hyunback <[email protected]>
isanghao pushed a commit that referenced this pull request Mar 8, 2023
* [GPU] Add data broadcasting for OneDNN binary ops for Gemm primitive
* Based on #15790 and enable onednn gemm from support multiple users and non constant input.

--------

Signed-off-by: hyunback <[email protected]>
Co-authored-by: Sergey Shlyapnikov <[email protected]>
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Mar 21, 2023
* [GPU] Add data broadcasting for OneDNN binary ops for Gemm primitive
* Based on openvinotoolkit#15790 and enable onednn gemm from support multiple users and non constant input.

--------

Signed-off-by: hyunback <[email protected]>
Co-authored-by: Sergey Shlyapnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants