[PT FE] Add prim::PythonOp #15714
Merged
[PT FE] Add prim::PythonOp #15714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Python API
mvafin
reviewed
Feb 14, 2023
mvafin
reviewed
Feb 14, 2023
|
|
||
| class prim_pythonop(torch.nn.Module): | ||
| def forward(self, input_tensor): | ||
| return torch.add(exp_f(input_tensor), 1) |
There was a problem hiding this comment.
Could you also add test for DeformableConvolution that we have in models?
There was a problem hiding this comment.
This op would add torchvision::deform_conv2d into unconverted OP, adding test would require to enable this op as well. I think it might be better to enable it in different PR to not mix it up, but if you want, I could enable this in current PR
mvafin
reviewed
Feb 14, 2023
tomdol
reviewed
Feb 15, 2023
mvafin
requested changes
Feb 16, 2023
Co-authored-by: Maxim Vafin <[email protected]>
…into mateuszm/pt/pythonop
tomdol
approved these changes
Feb 21, 2023
mvafin
requested changes
Feb 24, 2023
mvafin
approved these changes
Mar 2, 2023
Co-authored-by: Maxim Vafin <[email protected]>
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Mar 21, 2023
* Add PythonOp * Fix deprecation & cleanup * Apply suggestions from code review * Fix dtype * Apply suggestions from code review Co-authored-by: Maxim Vafin <[email protected]> * Update to new tensor names handling * Fix negation * Apply changes from code review * Remove unnecesary imports * Update src/frontends/pytorch/src/op/pythonop.cpp Co-authored-by: Maxim Vafin <[email protected]> --------- Co-authored-by: Maxim Vafin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: