Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Added Mish activation #1555

Merged

Conversation

a-sidorova
Copy link
Contributor

@a-sidorova a-sidorova commented Jul 30, 2020

Added Mish activation.

PR in OneDNN: openvinotoolkit/oneDNN#9

@a-sidorova a-sidorova changed the title [WIP] [CPU] Add Mish activation WIP: [CPU] Add Mish activation Jul 30, 2020
@a-sidorova a-sidorova force-pushed the feature/a-sidorova/mish branch 2 times, most recently from 2e7e2f0 to fdb0eb5 Compare August 4, 2020 12:12
@antonvor antonvor changed the title WIP: [CPU] Add Mish activation [CPU] Added Mish activation Aug 4, 2020
@antonvor
Copy link
Contributor

antonvor commented Aug 4, 2020

Where are tests?

@a-sidorova a-sidorova force-pushed the feature/a-sidorova/mish branch from fdb0eb5 to 5877b7f Compare August 4, 2020 12:36
Copy link
Contributor

@antonvor antonvor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonvor antonvor marked this pull request as ready for review August 4, 2020 12:56
@antonvor antonvor requested review from a team August 4, 2020 12:56
@antonvor antonvor added the category: CPU OpenVINO CPU plugin label Aug 4, 2020
@antonvor antonvor added this to the 2021.1 milestone Aug 4, 2020
@antonvor
Copy link
Contributor

antonvor commented Aug 4, 2020

@dmitry-gorokhov could you please review?

@antonvor antonvor assigned dmitry-gorokhov and unassigned antonvor Aug 4, 2020
@dmitry-gorokhov
Copy link
Contributor

@a-sidorova mkldnn submodule is not pointing on latest commit of openvinotoolkit/oneDNN#9. Please update it and I will merge the PR.

@a-sidorova a-sidorova force-pushed the feature/a-sidorova/mish branch from 5877b7f to 0d69ed3 Compare August 10, 2020 06:10
@a-sidorova a-sidorova force-pushed the feature/a-sidorova/mish branch from 0d69ed3 to cd4f5c0 Compare August 10, 2020 06:43
@a-sidorova
Copy link
Contributor Author

@a-sidorova mkldnn submodule is not pointing on latest commit of openvinotoolkit/oneDNN#9. Please update it and I will merge the PR.

Done

@dmitry-gorokhov dmitry-gorokhov merged commit 50e003c into openvinotoolkit:master Aug 10, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Aug 26, 2020
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants