Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snippets] Added support of BF16/I8/U8 for MatMul #15063
[Snippets] Added support of BF16/I8/U8 for MatMul #15063
Changes from 1 commit
10d5eb8
d58c60a
01d55cd
e9b7007
3f8bbcf
5deb3c3
c76f658
4d97db2
6b80c5d
5a6ba4b
5c31c6c
9719a4e
3934896
ea25c80
3b83287
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idx = 0
valueLoad
should I useset_input_count
orset_output_count
? And if onlyset_input_count
is legal for such operations, what happens if Iset_output_count
? I've seen that you createdset_count
forLoad
andStore
, and I think this is a right direction, but stillset_input_count
could be called on load, which is a bit confusing. I don't insist, but should we make a separate class for single-port operations maybe?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load
works with data on input and with vector register on output. So you should work withset_input_count
. And opposite forStore
. I thought that it seems like logical things. We can discuss it