Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GNA] Remove empty PWL #1459

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[GNA] Remove empty PWL #1459

merged 1 commit into from
Jul 28, 2020

Conversation

pavel-rodionov
Copy link
Contributor

@pavel-rodionov pavel-rodionov commented Jul 23, 2020 •
edited
Loading

Issue 33867

@pavel-rodionov pavel-rodionov added the category: GNA OpenVINO GNA plugin label Jul 23, 2020
@pavel-rodionov pavel-rodionov requested a review from esmirno July 23, 2020 20:44
@pavel-rodionov pavel-rodionov marked this pull request as ready for review July 23, 2020 20:44
@pavel-rodionov pavel-rodionov requested a review from a team July 23, 2020 20:44
@pavel-rodionov
Copy link
Contributor Author

CI passed @esmirno Could you please take a look?

esmirno
esmirno reviewed Jul 27, 2020
View reviewed changes
inference-engine/src/gna_plugin/backend/am_intel_dnn.cpp
@@ -1520,7 +1516,8 @@ void GNAPluginNS::backend::AMIntelDNN::InitGNAStruct(intel_nnet_type_t *ptr_nnet
THROW_GNA_EXCEPTION << "Pooling component with no preceeding component";
#if GNA_LIB_VER == 2
} else if (gnaOperation->Type == Gna2OperationTypeConvolution) {
if (gnaOperation->Operands[PwlOpIdx]->Shape.Dimensions[0] != 0) {
auto pwlOperand = gnaOperation->Operands[PwlOpIdx];
if (pwlOperand != nullptr && pwlOperand->Shape.Dimensions[0] != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pwlOperand != null seems enogh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's refine in the PR for the master branch.

dorloff
dorloff approved these changes Jul 28, 2020
View reviewed changes
inference-engine/src/gna_plugin/backend/am_intel_dnn.cpp
@@ -1520,7 +1516,8 @@ void GNAPluginNS::backend::AMIntelDNN::InitGNAStruct(intel_nnet_type_t *ptr_nnet
THROW_GNA_EXCEPTION << "Pooling component with no preceeding component";
#if GNA_LIB_VER == 2
} else if (gnaOperation->Type == Gna2OperationTypeConvolution) {
if (gnaOperation->Operands[PwlOpIdx]->Shape.Dimensions[0] != 0) {
auto pwlOperand = gnaOperation->Operands[PwlOpIdx];
if (pwlOperand != nullptr && pwlOperand->Shape.Dimensions[0] != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's refine in the PR for the master branch.

@asuhov asuhov merged commit 704dbcb into openvinotoolkit:releases/2020/4.0.1 Jul 28, 2020
dorloff pushed a commit to dorloff/openvino that referenced this pull request Aug 11, 2020
@pavel-rodionov @dorloff
[GNA] Remove empty PWL (openvinotoolkit#1459)
63e4114
evgenytalanin-intel pushed a commit that referenced this pull request Aug 14, 2020
@dorloff @pavel-rodionov
@esmirno @ilyachur @ntyukaev @Domi2000 @ilya-lavrenov @andrew-zaytsev
Merge 2020.4.0.1 (#1764)
c880ecb 
* [GNA] Update GNA lib + propagate QoS timeout to the calling app (#1188)

* [GNA] Remove empty PWL (#1459)

* [GNA] Support timeout value set in Wait (#1499)

* [GNA] Bump GNA2 version to 1010 (#1510)

* [GNA] stored request id for completed sync infer request in order to get status later using wait() (#1458)

* stored request id for completed async infer request in order to get it's status later

* preserved status not started for multiple sequential calls to wait()

Co-authored-by: Denis Orlov <[email protected]>

* [GNA] Fix callbacks (#1607)

* [GNA] Bump GNA2 version to 1047 (#1614)

* merge documentation updates from 2020/4 branch (#1671)

* update system requirements (#1321)

* update release version in readme

* Doc Migration from Gitlab (#1289)

* Update FakeQuantize_1.md

* Update performance_benchmarks.md

* Updates graphs for FPGA

* Update performance_benchmarks.md

* Change DL Workbench structure (#1)

* Changed DL Workbench structure

* Update performance_benchmarks_faq.md

* Fixes in DL Workbench layout

* Fixes for CVS-31290

* [DL Workbench] Minor correction

* Fix for CVS-30955

* Added nGraph deprecation notice as requested by Zoe

* fix broken links in api doxy layouts

* Fixed POT TOC

* Update PAC_Configure.md

PAC DCP 1.2.1 install guide.

* Update inference_engine_intro.md

* Update opset.md

* Update VisionAcceleratorFPGA_Configure.md (#1378)

Updated from 2020.3 to 2020.4

Co-authored-by: domi2000 <[email protected]>

* Updated documentation for 2020.4 (#1434)

* Updated documentation for 2020.4

* Updated Core::ReadNetwork documentation (#1178)

Co-authored-by: Ilya Churaev <[email protected]>
Co-authored-by: Nikolay Tyukaev <[email protected]>
Co-authored-by: domi2000 <[email protected]>
Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>

* Documentation updates for 2020.4 (#1672) (#1729)

* Doc updates

* 2020.4 doc updates

* Removed </br> tag

* Minor fix

* Minor fixes

* Updated documentation for 2020.4 (#1434)

* Updated documentation for 2020.4

* Updated Core::ReadNetwork documentation (#1178)

* Fixed docs

Co-authored-by: Ilya Churaev <[email protected]>

Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>

Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>

Co-authored-by: Pavel Rodionov <[email protected]>
Co-authored-by: Eugene Smirnov <[email protected]>
Co-authored-by: Alexey Suhov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>
Co-authored-by: Nikolay Tyukaev <[email protected]>
Co-authored-by: domi2000 <[email protected]>
Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Andrey Zaytsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esmirno esmirno esmirno left review comments

@dorloff dorloff dorloff approved these changes

Assignees
No one assigned
Labels
category: GNA OpenVINO GNA plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavel-rodionov @esmirno @dorloff @asuhov