[IE][VPU][nGraph]: Fixes StridedSlice DTS #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of Begin/End/Stride inputs of StridedSlice have rank less than input data rank - remaining dimensions must be kept unchanged Previous, implementation had UB in such cases - out of bound vector element access Signed-off-by: Gladilov, Gleb <[email protected]>
ggladilov
requested review from
Maxim-Doronin,
a user,
GlebKazantaev and
itikhono
itikhono
approved these changes
Jul 15, 2020
Maxim-Doronin
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
35007
Description
In case of Begin/End/Stride inputs of
StridedSlicehave rank less than input data rank - remaining dimensions must be kept unchanged.Previous, implementation had UB in such cases - out of bound vector element access. So,
StridedSlicewith configuration: data shape [X, Y], begin shape [B], end shape [E] and stride shape [S] will access memory outside of begin, end and strides bounds.