Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IE Myriad] Use instance of InferenceEngine::Core via ie::ICore interface in Myriad plugin #1316

Merged
merged 3 commits into from
Jul 29, 2020
Merged

[IE Myriad] Use instance of InferenceEngine::Core via ie::ICore interface in Myriad plugin #1316

merged 3 commits into from
Jul 29, 2020

Conversation

nikita-kud
Copy link
Contributor

@nikita-kud nikita-kud commented Jul 14, 2020 •
edited
Loading

#-30632
hddl PR 194

CI:

  • 1296

Nets:

  • 147

Pre-commit 12992 is passed

@ilya-lavrenov ilya-lavrenov added this to the 2021.1 milestone Jul 14, 2020
@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch from 422eea6 to 7061559 Compare July 16, 2020 09:45
@nikita-kud nikita-kud marked this pull request as ready for review July 16, 2020 09:46
@nikita-kud nikita-kud requested a review from a team as a code owner July 16, 2020 09:46
@nikita-kud nikita-kud changed the title [IE Myriad] Use instance of InferenceEngine::Core via ie::ICore interface in Myriad plugin WIP: [IE Myriad] Use instance of InferenceEngine::Core via ie::ICore interface in Myriad plugin Jul 16, 2020
@DariaMityagina
Copy link
Contributor

Approved the changes, they are fine. But the failures have to be fixed, as I can see out of logs there are some problems with adding new parameter like candidate expects 2 arguments, 1 provided and so on.

@nikita-kud nikita-kud requested a review from a team July 16, 2020 12:37
@nikita-kud nikita-kud changed the title WIP: [IE Myriad] Use instance of InferenceEngine::Core via ie::ICore interface in Myriad plugin [IE Myriad] Use instance of InferenceEngine::Core via ie::ICore interface in Myriad plugin Jul 16, 2020
@iefode iefode added the category: IE Tests OpenVINO Test: plugins and common label Jul 16, 2020
@ggladilov ggladilov requested a review from Maxim-Doronin July 16, 2020 13:01
@ggladilov
Copy link
Contributor

@Maxim-Doronin FYI

@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch 2 times, most recently from 2ef870c to 119cc95 Compare July 16, 2020 17:26
@nikita-kud nikita-kud requested a review from iefode July 16, 2020 17:30
@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch from 119cc95 to fd3c21b Compare July 17, 2020 08:26
@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch from fd3c21b to 5b7f8dd Compare July 17, 2020 12:42
@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch 4 times, most recently from b2105f7 to e9acfa2 Compare July 22, 2020 08:46
@nikita-kud nikita-kud requested a review from a team as a code owner July 22, 2020 08:46
@nikita-kud nikita-kud requested a review from a team July 22, 2020 08:46
@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch 3 times, most recently from 94da074 to 01b8fc3 Compare July 22, 2020 13:12
@Maxim-Doronin
Copy link
Contributor

@nikita-kud, the mentioned in PR description validation build is not ok. Could you re-run validation?

@nikita-kud
Copy link
Contributor Author

Could you re-run validation?

Unfortunately, pre-commit is still red:( So I will run the internal CI when it is fixed.

@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch 2 times, most recently from 22140a4 to 37a1b88 Compare July 24, 2020 11:58
@nikita-kud
Copy link
Contributor Author

@iefode @ilya-lavrenov please take a look.

@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch 2 times, most recently from 27a94d5 to c52c719 Compare July 24, 2020 16:21
@nikita-kud
Copy link
Contributor Author

@Maxim-Doronin please take a look.
Pre-commit passed

@nikita-kud nikita-kud force-pushed the vpu/n_kud/use_core_via_interface branch 2 times, most recently from 03670c1 to 870ec1c Compare July 28, 2020 15:51
@azhogov azhogov merged commit a644cb8 into openvinotoolkit:master Jul 29, 2020
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
@nikita-kud
[IE Myriad] Use instance of InferenceEngine::Core via ie::ICore inter…
ca248de 
…face in Myriad plugin (openvinotoolkit#1316)

* [ci-skip][IE Myriad] ie::ICore pointer passed into FrontEnd from plugin

* [ci-skip][IE Myriad] Added MockICore to fix graph transformer tests

* [ci-skip][IE Myriad] IN renamed to I_N to avoid compile error in Windows build: C2513: 'int': no variable declared before '='
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorA6 KorA6 KorA6 approved these changes

@DariaMityagina DariaMityagina DariaMityagina approved these changes

@iefode iefode iefode approved these changes

@Maxim-Doronin Maxim-Doronin Maxim-Doronin approved these changes

@ggladilov ggladilov ggladilov approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Assignees

@Maxim-Doronin Maxim-Doronin

@nikita-kud nikita-kud

Labels
category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.
8 participants
@nikita-kud @DariaMityagina @ggladilov @Maxim-Doronin @ilya-lavrenov @iefode @KorA6 @azhogov