Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyOV] Added deprecation function #12540

Merged

Conversation

adrianboguszewski
Copy link
Contributor

Details:

  • Add deprecation warning in c++ common namespace
  • Add python binding
  • Add python deprecation decorator

Tickets:

  • 82660

@adrianboguszewski adrianboguszewski added the category: Python API OpenVINO Python bindings label Aug 12, 2022
@adrianboguszewski adrianboguszewski requested a review from a team as a code owner August 12, 2022 16:58
@adrianboguszewski adrianboguszewski force-pushed the feature/deprecation-function branch from 86fd102 to ccfab41 Compare August 15, 2022 12:21
@p-wysocki
Copy link
Contributor

We also could use a binding test, probably somewhere in openvino/src/bindings/python/tests/test_utils/test_utils.py.
Additionally, it would be great to use this function in places where we use old, inconsistent deprecation warnings - it has already been discussed with @adrianboguszewski and is work in progress.

@adrianboguszewski adrianboguszewski force-pushed the feature/deprecation-function branch from d5c4c99 to ef2ad75 Compare August 19, 2022 14:09
@adrianboguszewski adrianboguszewski force-pushed the feature/deprecation-function branch from f76c792 to fabc532 Compare August 22, 2022 12:26
Copy link
Contributor

@p-wysocki p-wysocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianboguszewski adrianboguszewski force-pushed the feature/deprecation-function branch from 4a00764 to cf7a970 Compare August 31, 2022 11:56
@adrianboguszewski adrianboguszewski force-pushed the feature/deprecation-function branch from cf7a970 to 73231fc Compare August 31, 2022 14:09
@jiwaszki jiwaszki merged commit 27c1c6a into openvinotoolkit:master Sep 5, 2022
@adrianboguszewski adrianboguszewski deleted the feature/deprecation-function branch September 6, 2022 13:34
@adrianboguszewski adrianboguszewski restored the feature/deprecation-function branch September 9, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Python API OpenVINO Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants