[CPU] Removed contexts from Load/Store emitters #12446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
from
0f270c4 to
f30705a
Compare
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
3 times, most recently
from
3232a90 to
467483c
Compare
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
2 times, most recently
from
958ab3f to
2f8b55a
Compare
|
@a-sidorova It is always a good practice to put motivation of the changes directly in the description of the PR. |
|
@xuchen-intel @chenhu-wang FYI. If you have any comments feel free to add. |
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
from
2f8b55a to
34164b6
Compare
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
from
34164b6 to
4aea160
Compare
dmitry-gorokhov
approved these changes
Aug 14, 2022
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
from
4aea160 to
8fa8d92
Compare
chenhu-wang
reviewed
Aug 15, 2022
chenhu-wang
reviewed
Aug 15, 2022
chenhu-wang
reviewed
Aug 15, 2022
chenhu-wang
approved these changes
Aug 15, 2022
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
from
02deb5c to
37add92
Compare
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
3 times, most recently
from
939ad6e to
1f22e69
Compare
|
@chenhu-wang thanks a lot! @dmitry-gorokhov DLB has been passed. The reports are attached to the ticket |
a-sidorova
force-pushed
the
feature/emitters/remove_contexts
branch
from
258b081 to
15e091f
Compare
a-sidorova
added a commit
to a-sidorova/openvino
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Storepollutessrc_vmmregister in cases when src and dst precisions are different. So in the next stage in jit pipeline oursrc_vmmcan be broken. To avoid additionalaux_vmmin each store emitter this PR removes contexts to create exact emitter using ctor. Thus, count of aux registers is known it the moment emitter creation and this count is different for each case (at the moment in masterStoreandLoademitters have hardcoded count of aux regsInterpolate,MVN,NMS,ROI Align,ROI Pooling,TopK,ColorConvertTickets: