【PaddlePaddle Hackathon 3】No.102：为 OpenVINO 实现 Paddle 算子 elementwise_floordiv 转换 #12186
Conversation
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_floordiv.py
Outdated
Show resolved
Hide resolved
|
@meiyang-intel Could you help to take a look ? thanks |
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_floordiv.py
Outdated
Show resolved
Hide resolved
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_floordiv.py
Outdated
Show resolved
Hide resolved
| if ((axis == -1) || (axis == x_rank - 1) || (x_rank == y_rank)) { | ||
| return node_context.default_single_output_mapping({std::make_shared<default_opset::Floor>(std::make_shared<default_opset::Divide>(x, y))}, {"Out"}); | ||
| } else { | ||
| std::vector<int64_t> indices; |
There was a problem hiding this comment.
Can we use broadcast to address the case when x and y have different rank?
There was a problem hiding this comment.
这里参考的是elementwise_ops原始代码中的实现，里面手动进行brodcast的，没看到自动broadcast的例子，有参考实现代码吗？
There was a problem hiding this comment.
Please develop such kind of test cases. And apply openvino AutoBroadcastSpec to the op mapper.
There was a problem hiding this comment.
test case后面添加。
能否给个调用的例子参考呀，或者文档链接来着？
比如，实现” x + y“的调用例子，x与y不同维度，且y需要brodcast的例子？
There was a problem hiding this comment.
Please comment in English. The reviewers from abroad. Thanks.
There was a problem hiding this comment.
hi, i found an error in paddlepaddle floor_divide.
if value is a negative number eg."-0.2", paddle will use "ceil", the value will be "0"
if value is a positive number eg "1.2", paddle will user "floor" the value will be "1".
this is a demo.
import numpy as np
x = np.array([1, 2, -3])
y = np.array([-2, 1, 2])
np.floor_divide(x, y)
# [-1, 2, -2]
import paddle
paddle.set_device("cpu")
x = paddle.to_tensor([1, 2, -3])
y = paddle.to_tensor([-2, 1, 2])
paddle.floor_divide(x, y)
# [0, 2, -1]
paddle.floor( x.astype("float32") / y.astype("float32")).astype("int65")
# [-1, 2, -2]There was a problem hiding this comment.
i open a issue in paddlepaddle PaddlePaddle/Paddle#46379
There was a problem hiding this comment.
default_opset::Divide is equal "numpy floor divide".
There was a problem hiding this comment.
not ceil and floor , actualy use trunc
There was a problem hiding this comment.
Great finding! Thanks for this. We will collaborate with Paddle to see how to resolve this conflict.
|
Since no feedback from contributor for 2 weeks, this PR will be pending for review. |
|
doing |
|
done must use floor(divide(x, y)) |
glare-ni
requested review from
ceciliapeng2011,
openvino-dev-samples and
meiyang-intel
and removed request for
ceciliapeng2011 and
openvino-dev-samples
glare-ni
requested review from
ceciliapeng2011
and removed request for
meiyang-intel
|
This PR will be closed in 2 weeks in case of no activity. |
|
This PR was closed because it has been stalled for 2 week with no activity. |
Details:
elementwise_floordivoperation in Paddle front endReference:
Test: