Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support parallel nested nnet for Kaldi #1194

Merged
merged 3 commits into from
Jul 23, 2020
Merged

support parallel nested nnet for Kaldi #1194

merged 3 commits into from
Jul 23, 2020

Conversation

pavel-esir
Copy link
Contributor

@pavel-esir pavel-esir commented Jul 2, 2020 •
edited
Loading

Description: Changed Slice -> AttributedVariadicSplit while parsing ParalllelComponent (comes alongside with NestedNnet) in Kaldi loader.

JIRA: CVS-34431

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR: N/A -- no new transformations were added
  • Transformation preserves original framework node names: N/A -- because no transformation were added

Validation:

  • Unit tests: will be added in a separate PR Reshape able slice #1241
  • Framework operation tests: N/A -- no new operations were added
  • Transformation tests: N/A -- no new transformations were added
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py: N/A
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list: N/A
  • Supported public models list: N/A
  • New operations specification: N/A
  • Guide on how to convert the public model: N/A
  • User guide update: N/A

lazarevevgeny
lazarevevgeny suggested changes Jul 3, 2020
View reviewed changes
model-optimizer/mo/front/kaldi/extractors/slice_ext.py Show resolved Hide resolved
model-optimizer/mo/front/kaldi/loader/loader.py Outdated Show resolved Hide resolved
model-optimizer/mo/front/kaldi/loader/loader.py Outdated Show resolved Hide resolved
model-optimizer/mo/front/kaldi/loader/loader.py Outdated Show resolved Hide resolved
model-optimizer/mo/front/kaldi/loader/loader.py Outdated Show resolved Hide resolved
model-optimizer/mo/front/kaldi/loader/loader.py Outdated Show resolved Hide resolved
sadolini
sadolini reviewed Jul 4, 2020
View reviewed changes
Copy link
Contributor

@sadolini sadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be usefull to add unit test for parallel component loading in loader_test file

@pavel-esir
Copy link
Contributor Author

I think it will be usefull to add unit test for parallel component loading in loader_test file

ok, I'll do it

@pavel-esir pavel-esir mentioned this pull request Jul 7, 2020
Merged
14 tasks
@pavel-esir pavel-esir force-pushed the support_nested_nnet1_for_kaldi branch from 10f2705 to 8195ca7 Compare July 8, 2020 06:07
@ilya-lavrenov ilya-lavrenov added the category: MO Model Optimizer label Jul 8, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2021.1 milestone Jul 8, 2020
@pavel-esir pavel-esir force-pushed the support_nested_nnet1_for_kaldi branch from 8195ca7 to baf2b02 Compare July 23, 2020 09:56
@pavel-esir
Copy link
Contributor Author

Unittests will be added in a separate PR #1241
CI checks have been completed,@lazarevevgeny, please merge.

@lazarevevgeny lazarevevgeny merged commit e56c8a2 into openvinotoolkit:master Jul 23, 2020
bsochack pushed a commit to bsochack/openvino that referenced this pull request Jul 24, 2020
@pavel-esir
support parallel nested nnet for Kaldi (openvinotoolkit#1194)
6287f2f 
* supported nested nnet1 for Kaldi
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
@pavel-esir
support parallel nested nnet for Kaldi (openvinotoolkit#1194)
1d80ffc 
* supported nested nnet1 for Kaldi
@pavel-esir pavel-esir deleted the support_nested_nnet1_for_kaldi branch September 18, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadolini sadolini sadolini left review comments

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@dorloff dorloff Awaiting requested review from dorloff

@jane-intel jane-intel Awaiting requested review from jane-intel

Assignees
No one assigned
Labels
category: MO Model Optimizer
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.
4 participants
@pavel-esir @lazarevevgeny @sadolini @ilya-lavrenov