Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmartReshape: support Param->Convert->Reshape->Proposal pattern #10204

Merged
merged 1 commit into from
Feb 9, 2022
Merged

SmartReshape: support Param->Convert->Reshape->Proposal pattern #10204

merged 1 commit into from
Feb 9, 2022

Conversation

nosovmik
Copy link
Contributor

@nosovmik nosovmik commented Feb 8, 2022

Details:

  • Current Proposal1Scales/Proposal4Scales finds matched to Param->Reshape->Proposal patterns
    For FP16 models, there is additional 'Convert' is inserted after 'Parameter'.
    It causes transformation is not applied and 'ov::set_batch' or CNNNetwork::set_batch will throw
    Proposal1Scales and Proposal4Scales transformations were updated to handle these conditions
  • Tests were added to existing ieFuncTests (based on API 1.0)

Tickets:

  • 77382

@openvino-pushbot openvino-pushbot added category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels Feb 8, 2022
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Feb 8, 2022
GlebKazantaev
GlebKazantaev approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@GlebKazantaev GlebKazantaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transformation part looks good.

@nosovmik
SmartReshape: support Param->Convert->Reshape->Proposal pattern
7eeedfa 
    Current SmartReshape finds matched to Param->Reshape->Proposal patterns

    For FP16 models, there is additional 'Convert' is inserted after 'Parameter'.

    It causes transformation is not applied and 'ov::set_batch' or CNNNetwork::set_batch will throw

    Proposal1Scales and Proposal4Scales transformations were updated to handle these conditions
@jane-intel jane-intel merged commit f56c640 into openvinotoolkit:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jane-intel jane-intel jane-intel approved these changes

@GlebKazantaev GlebKazantaev GlebKazantaev approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@SmirnovGrigory SmirnovGrigory Awaiting requested review from SmirnovGrigory

Assignees

@jane-intel jane-intel

Labels
category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
5 participants
@nosovmik @ilya-lavrenov @GlebKazantaev @jane-intel @openvino-pushbot