Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dynamism from API 1.0 #10167

Merged
merged 6 commits into from
Feb 13, 2022
Merged

Remove dynamism from API 1.0 #10167

merged 6 commits into from
Feb 13, 2022

Conversation

nosovmik
Copy link
Contributor

@nosovmik nosovmik commented Feb 7, 2022 •
edited
Loading

Details:

Tickets:

  • 67989

@nosovmik nosovmik requested review from a team February 7, 2022 10:46
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Feb 7, 2022
@ilya-lavrenov ilya-lavrenov self-assigned this Feb 7, 2022
@openvino-pushbot openvino-pushbot added category: TEMPLATE OpenVINO Template plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference labels Feb 7, 2022
@nosovmik nosovmik requested review from a team February 7, 2022 17:27
@nosovmik nosovmik force-pushed the remove_dynamism_1_0 branch from 7c6dc7b to 5e7a764 Compare February 11, 2022 07:43
@nosovmik nosovmik changed the title [Draft/Don't review or merge] Remove dynamism from API 1.0 Remove dynamism from API 1.0 Feb 11, 2022
ilya-lavrenov
ilya-lavrenov reviewed Feb 11, 2022
View reviewed changes
docs/template_plugin/src/template_infer_request.cpp
@@ -476,17 +469,21 @@ void TemplateInferRequest::SetBlob(const std::string& name, const InferenceEngin
IE_THROW(NotAllocated) << "Failed to set empty blob with name: \'" << name << "\'";
InputInfo::Ptr foundInput;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we remove usage of old foundInput and foundOutput ? In this case we will rely on new _results and _parameters which are introduced in OV 2.0 and they have information about dynamism.
In this case we don't need to play with has_zeros, because in general we want template plugin to work only with OV 2.0 and ov::Model

src/inference/src/ie_core.cpp Outdated Show resolved Hide resolved
src/inference/src/ie_core.cpp Show resolved Hide resolved
src/tests/functional/inference_engine/cnn_network_test.cpp Show resolved Hide resolved
akuporos
akuporos approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@akuporos akuporos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok from Python API perspective

@nosovmik nosovmik merged commit d85715f into openvinotoolkit:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuporos akuporos akuporos approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@ilyachur ilyachur Awaiting requested review from ilyachur

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nosovmik @ilya-lavrenov @akuporos @openvino-pushbot