Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'evaluate' from I420toRGB/BGR operations #10128

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

nosovmik
Copy link
Contributor

@nosovmik nosovmik commented Feb 4, 2022

Details:

  • Remove 'evaluate' from I420toRGB/BGR operations, moved them to Template plugin
  • This reduces a bit binary size of 'openvino' library. CPU plugin has their own implementation now, so fallback to reference implementation is not needed anymore

Tickets:

  • 71714

@nosovmik nosovmik requested review from ilya-lavrenov, ilyachur and a team February 4, 2022 09:59
@openvino-pushbot openvino-pushbot added category: TEMPLATE OpenVINO Template plugin category: Core OpenVINO Core (aka ngraph) labels Feb 4, 2022
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) February 4, 2022 10:15
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Feb 4, 2022
@ilya-lavrenov ilya-lavrenov self-assigned this Feb 4, 2022
@@ -7,7 +7,6 @@
#include <ngraph/validation_util.hpp>

#include "itt.hpp"
#include "ngraph/runtime/reference/convert_color_nv12.hpp"
#include "openvino/core/layout.hpp"

namespace i420_op {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like OSX reports unused variables below

@ilya-lavrenov ilya-lavrenov merged commit abda6eb into openvinotoolkit:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants