Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Expose Model get/set _friendly_name() method to Node.js API #23566

Closed
almilosz opened this issue Mar 20, 2024 · 2 comments · Fixed by #23743
Closed

[Good First Issue]: Expose Model get/set _friendly_name() method to Node.js API #23566

almilosz opened this issue Mar 20, 2024 · 2 comments · Fixed by #23743
Assignees
@qxprakash
Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers gsoc-prerequisite-task Prerequisite task related to Google Summer of Code projects no_stale Do not mark as stale
Milestone
2024.2

Comments

@almilosz
Copy link
Contributor

Context

Node.js API is the newest binding of OpenVINO.
The task is to expose 2 methods:

You can take a look at C++ or Python API documentation.

What needs to be done?

  • add methods on C++ side (src/bindings/js/node/src/model.cpp)
  • update TypeScript definition (src/bindings/js/node/lib/addon.ts)
  • create unit test for added functionality using Node.js Test Runner

Note: Remember about parameter validation

Example Pull Requests

Here is the link to a PR with a very similar task that covers the steps listed above:

Resources

Contact points

@almilosz @vishniakov-nikolai

Ticket

No response
@almilosz almilosz added good first issue Good for newcomers category: JS API OpenVino JS API Bindings no_stale Do not mark as stale gsoc-prerequisite-task Prerequisite task related to Google Summer of Code projects labels Mar 20, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 20, 2024
@qxprakash
Copy link
Contributor

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Mar 20, 2024
@qxprakash qxprakash mentioned this issue Mar 28, 2024
Merged
@vishniakov-nikolai vishniakov-nikolai moved this from Assigned to In Review in Good first issues Mar 28, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
@qxprakash @vishniakov-nikolai
[OV JS] Expose Model.setFriendlyName and Model.getFriendlyName method…
fd59da5 
…s to Node.js api (#23743)

This fixes #23566   

Implemented Model.setFriendlyName and Model.getFriendlyName in Node.js
api

- Added Parameter Validation
- Added Tests in model.test.js

---------

Co-authored-by: Vishniakov Nikolai <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Apr 17, 2024
@mlukasze mlukasze added this to the 2024.2 milestone Apr 17, 2024
alvoron pushed a commit to alvoron/openvino that referenced this issue Apr 29, 2024
@qxprakash @vishniakov-nikolai @alvoron
[OV JS] Expose Model.setFriendlyName and Model.getFriendlyName method…
882e3b3 
…s to Node.js api (openvinotoolkit#23743)

This fixes openvinotoolkit#23566   

Implemented Model.setFriendlyName and Model.getFriendlyName in Node.js
api

- Added Parameter Validation
- Added Tests in model.test.js

---------

Co-authored-by: Vishniakov Nikolai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qxprakash qxprakash

Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers gsoc-prerequisite-task Prerequisite task related to Google Summer of Code projects no_stale Do not mark as stale
Projects
Good first issues
Archived in project
Milestone
2024.2
3 participants
@mlukasze @qxprakash @almilosz