Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Support aten::index_fill_ for pytorch models #23326

Closed
mvafin opened this issue Mar 7, 2024 · 16 comments · Fixed by #27420
Closed

[Good First Issue]: Support aten::index_fill_ for pytorch models #23326

mvafin opened this issue Mar 7, 2024 · 16 comments · Fixed by #27420
Assignees
@cocoshe
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Milestone
2025.0

Comments

@mvafin
Copy link
Contributor

mvafin commented Mar 7, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD
@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 7, 2024
@AKFORTY7
Copy link

AKFORTY7 commented Mar 9, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@rkazants rkazants moved this from Contributors Needed to Assigned in Good first issues Mar 9, 2024
@p-wysocki p-wysocki moved this from Assigned to Contributors Needed in Good first issues Apr 3, 2024
@p-wysocki
Copy link
Contributor

I reopened the issue due to current assignee's inactivity.

@atharvameshram
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Apr 4, 2024
@p-wysocki p-wysocki moved this from Assigned to Contributors Needed in Good first issues May 6, 2024
@muhd360
Copy link

muhd360 commented Aug 31, 2024

I would like to be assigned this issue

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Sep 2, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Sep 2, 2024

the task is yours now @muhd360 :)

@muhd360
Copy link

muhd360 commented Sep 2, 2024

thanks

@mlukasze
Copy link
Contributor

hey @muhd360 any help needed?

@muhd360
Copy link

muhd360 commented Sep 18, 2024

hi @mlukasze pls refrence this convo #26488

@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Sep 18, 2024
@mlukasze mlukasze linked a pull request Sep 18, 2024 that will close this issue
Index fill pytorch #26488
Closed
@cocoshe
Copy link
Contributor

cocoshe commented Oct 31, 2024

Hello there! @mvafin @mlukasze @p-wysocki May I take the issue?

@mlukasze
Copy link
Contributor

mlukasze commented Nov 6, 2024

@cocoshe - it's all yours, have fun!

@mlukasze mlukasze moved this from In Review to Assigned in Good first issues Nov 6, 2024
@cocoshe cocoshe mentioned this issue Nov 6, 2024
Merged
@cocoshe
Copy link
Contributor

cocoshe commented Nov 9, 2024

@mlukasze Hi, pls review my pr here~ #27420

@mlukasze mlukasze linked a pull request Nov 12, 2024 that will close this issue
[feat]: index_fill_ frontend pytorch op #27420
Merged
@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Nov 12, 2024
@cocoshe
Copy link
Contributor

cocoshe commented Nov 20, 2024

@mlukasze Anything else needs to be done? Or just wait for the review?👀

@mlukasze
Copy link
Contributor

yes, we are waiting for the review, sorry for the delay, it's on us

@cocoshe
Copy link
Contributor

cocoshe commented Nov 20, 2024

yes, we are waiting for the review, sorry for the delay, it's on us

Never mind~

github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
@cocoshe @mvafin
[feat]: index_fill_ frontend pytorch op (#27420)
17e17b2 
### Details:

Add support for aten::index_fill_ for pytorch models

### Tickets:

[#23326](#23326)

---------

Co-authored-by: Maxim Vafin <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Nov 26, 2024
@mlukasze mlukasze added this to the 2025.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cocoshe cocoshe

Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Status: Closed
Milestone
2025.0
Development

Successfully merging a pull request may close this issue.

[feat]: index_fill_ frontend pytorch op cocoshe/openvino
Index fill pytorch muhd360/openvino
7 participants
@mvafin @mlukasze @p-wysocki @cocoshe @atharvameshram @AKFORTY7 @muhd360