Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::replication_pad{1,2,3}d for pytorch models #23322

Open
mvafin opened this issue Mar 7, 2024 · 4 comments
Open
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Mar 7, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 7, 2024
@AKFORTY7
Copy link

AKFORTY7 commented Mar 9, 2024

.take

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@rkazants rkazants moved this from Contributors Needed to Assigned in Good first issues Mar 9, 2024
@p-wysocki p-wysocki moved this from Assigned to Contributors Needed in Good first issues Apr 3, 2024
@p-wysocki
Copy link
Contributor

I reopened the issue due to current assignee's inactivity.

Collins-Webdev added a commit to Collins-Webdev/openvino that referenced this issue Apr 4, 2024
Modifications:

Implemented conversion rule and/or transformation to support the new operation.
Added operation tests in pytorch_tests covering different data types.
Enhanced readability and clarity of the code by organizing imports and comments.
Added descriptive docstrings to functions and classes for better documentation.
Refactored variable names and function definitions to adhere to PEP8 guidelines.
Improved code structure and logic for better maintainability and scalability.
Optimized code performance by reducing unnecessary computations and memory usage.
Ensured consistency in coding style and conventions throughout the file.
@Collins-Webdev
Copy link

Hello @p-wysocki , I made a pull-request about it here .

Please review the changes and let me know if there are any further adjustments needed. Thank you for considering my contribution.

@mlukasze mlukasze moved this from Contributors Needed to In Review in Good first issues Apr 5, 2024
@mlukasze mlukasze linked a pull request Apr 5, 2024 that will close this issue
@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Contributors Needed
Development

Successfully merging a pull request may close this issue.

4 participants