[Good First Issue]: Support aten::atan2 for pytorch models

[mvafin]

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

• Implement conversion rule and/or transformation to support the new operation.
• Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

• torch.atan2 description
• What is OpenVINO?
• OpenVINO PyTorch Frontend
• How to build OpenVINO
• Contribution guide
• Blog post on contributing to OpenVINO
• User documentation

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

[stncil]

Hi, I am new to open-source contribution. Could you point me to a resource that tells me how to compile and contribute to this project?

[stncil]

Hi, thank you for assigning the task. However, I am not sure how I would begin the implementation.
Could you please point me to a resource regarding compiling the project?

[ilya-lavrenov]

Hi @stncil
This information is a part of our Wiki https://github.com/openvinotoolkit/openvino/wiki and here is a link https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/build.md

[p-wysocki]

Hi @stncil, are you still working on this issue or can I return it to be picked up by other contributors?

[stncil]

Hi, I won't be able to complete the task. Please return it to the open issues. Apologies for the delay in response.

[sydarb]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[p-wysocki]

Hello @sydarb, thanks for taking a look! Please let us know if you have any questions or need any help. :)

You can use our WIP roadmap for contributors at #21322, if you do - please let us know if it helped and give us any feedback on how it could be improved. :)

[p-wysocki]

Hello @sydarb, are you still working on this issue?

I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

[sahilpmehra]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[sahilpmehra]

Hi @p-wysocki @mvafin, I am facing a little issue while building openvino on my macbook (apple silicon). I have followed the apple silicon related guide so far (https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/build_mac_arm.md).

cmake -G "Ninja Multi-Config" -DENABLE_SYSTEM_PUGIXML=ON -DENABLE_SYSTEM_SNAPPY=ON -DENABLE_SYSTEM_PROTOBUF=ON ..

The issue comes up with the above step when I am running cmake to fetch project dependencies and create build rules.

After receiving a few warnings related to which functionality is turned off (expected), I get the following error message:

CMake Error at cmake/developer_package/cross_compile/find_commands.cmake:152 (find_program):
Could not find SCONS using the following names: scons
Call Stack (most recent call first):
src/plugins/intel_cpu/thirdparty/ACLConfig.cmake:109 (find_host_program)
src/plugins/intel_cpu/thirdparty/FindACL.cmake:5 (include)
src/plugins/intel_cpu/thirdparty/onednn/cmake/ACL.cmake:32 (find_package)
src/plugins/intel_cpu/thirdparty/onednn/CMakeLists.txt:129 (include)

Is this a known issue while building with Apple Silicon? Or is there some other issue? Please let me know if you have seen this before. Would be very grateful!

[ilya-lavrenov]

Hi @sahilpmehra you missed several steps with dependency installation. Specifically, you have missed:

brew install scons

Note, it can also be installed via python3 -m pip.

[p-wysocki]

Hi @sahilpmehra, are you still working on that issue?

[rghvsh]

#23003

[rghvsh]

Hey @mvafin made the recommended changes please review once.

[Increshi]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[mlukasze]

hey @Increshi do you need any support?

[tiebreaker4869]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[tiebreaker4869]

hi @mlukasze :) , i just finish working on it and open a pr, should i do something or just wait for review.

[mlukasze]

hi @mlukasze :) , i just finish working on it and open a pr, should i do something or just wait for review.

no, reviewers received notifications, no we wait ;)

[mlukasze]

@mvafin will be your contact point to solve those issues and answers questions.

[tiebreaker4869]

@mvafin will be your contact point to solve those issues and answers questions.

okay, thank you.

[tiebreaker4869]

hi @mvafin i just encountered some issues in the CI pytorch layer tests.

in the test logs it reports errors about "no conversion rules for aten.atan2.default", but there is only aten::atan2 operator.

i try to reproduce using the command to run pytest locally on my mac but it runs normally. could you provide some hints about where could this "aten.atan2.default" come from or any ways to inspect it? thanks a lot!