Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Align behavior of ONNX Frontend function ReduceLogSum-11, 13, 18 with original framework #20561

Closed
gkrivor opened this issue Oct 18, 2023 · 8 comments · Fixed by #23508
Assignees
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers no_stale Do not mark as stale ONNX Related to support for ONNX standard.
Milestone

Comments

@gkrivor
Copy link
Contributor

gkrivor commented Oct 18, 2023

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.
OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.
This task requires alignment between OpenVINO ONNX Frontend and original framework implementations of ReduceLogSum for next list of opsets: opset 11, opset 13, opset 18
Necessary help will be provided by ONNX Fronted team.

What needs to be done?

First of all, please, take a look on ReduceMax PR for a reference.

Operator details can be found in ONNX Operators
More details can be found in ONNX Changelog: opset 11, opset 13, opset 18

  1. Function already has a common implementation in OpenVINO. First of all, you need to review a documentation and prepare a table with differences between versions. It could be, for instance, a missing property, extended/reduced coverage of existing property, etc...
  2. Copy existing implementation here to make it aligned with original framework (extend or reduce coverage of a common implementation). Copy of modified implementation should be in a defined opset, or in opset 1 in case it implements oldest implementation. Example of multi-opset operation.
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here
  6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test".
    More details in adding operators to ONNX Frontend guide

Example Pull Requests

No response

Resources

Contact points

@gkrivor

Ticket

No response

@gkrivor gkrivor added good first issue Good for newcomers category: ONNX FE OpenVINO ONNX FrontEnd no_stale Do not mark as stale labels Oct 18, 2023
@github-project-automation github-project-automation bot moved this to Contrubutors needed in Good first issues Oct 18, 2023
@mlukasze mlukasze added the ONNX Related to support for ONNX standard. label Oct 26, 2023
@Hunter-bitbit
Copy link

Hi! I'm a first time contributor. Could this issue be assigned to me?

@mlukasze mlukasze assigned mlukasze and Hunter-bitbit and unassigned mlukasze Feb 9, 2024
@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Feb 9, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Feb 9, 2024

It's yours now :)

@p-wysocki
Copy link
Contributor

Hello @Hunter-bitbit, do you need any help from us? :)

@Hunter-bitbit
Copy link

Hunter-bitbit commented Feb 21, 2024

Hi @p-wysocki, some help would be great, yes. I'm mostly just having issues with understanding what needs to be done. I made the table of differences between versions, but steps 2 and 3 don't make much sense to me. I found the existing implementation but I don't know where to copy it to? For the registration I found a ReducedLogSum in there... do I have to specify the namespace it's in? I'm just very confused as to what I actually have to do since it seems like everything is already implemented... sorry for the hassle :\

@p-wysocki
Copy link
Contributor

Hello @Hunter-bitbit, it may be the case that the operator is currently correctly aligned. Could you please give a brief summary of the changes between op versions and what OpenVINO has? That would simplify the discussion a lot. cc @gkrivor

@p-wysocki p-wysocki moved this from Assigned to Contributors Needed in Good first issues Mar 1, 2024
@mengbingrock
Copy link

.take

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mengbingrock
Copy link

Hi,
The PR is created:
23522

@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Mar 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
### Details:
 - Extended ReduceLogSum by opsets 11,13,18


### Tickets:
 - Closes #20561

---------

Co-authored-by: Katarzyna Mitrus <[email protected]>
Co-authored-by: Georgy Krivoruchko <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Mar 28, 2024
@mlukasze mlukasze added this to the 2024.1 milestone Apr 5, 2024
bbielawx pushed a commit to bbielawx/openvino that referenced this issue Apr 12, 2024
### Details:
 - Extended ReduceLogSum by opsets 11,13,18


### Tickets:
 - Closes openvinotoolkit#20561

---------

Co-authored-by: Katarzyna Mitrus <[email protected]>
Co-authored-by: Georgy Krivoruchko <[email protected]>
alvoron pushed a commit to alvoron/openvino that referenced this issue Apr 29, 2024
### Details:
 - Extended ReduceLogSum by opsets 11,13,18


### Tickets:
 - Closes openvinotoolkit#20561

---------

Co-authored-by: Katarzyna Mitrus <[email protected]>
Co-authored-by: Georgy Krivoruchko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers no_stale Do not mark as stale ONNX Related to support for ONNX standard.
Projects
Archived in project
5 participants