Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][TF FE] Support for complex tensorflow ops #11800

Closed
lminer opened this issue Jun 6, 2022 · 18 comments
Closed

[Feature Request][TF FE] Support for complex tensorflow ops #11800

lminer opened this issue Jun 6, 2022 · 18 comments
Assignees
Labels
category: MO Model Optimizer category: TF FE OpenVINO TensorFlow FrontEnd feature New feature request PSE

Comments

@lminer
Copy link

lminer commented Jun 6, 2022

It would be great to get support for tensorflow complex ops: Complex, Real, Imag.

These ops are essential for anyone working with audio data.

@jgespino jgespino self-assigned this Jun 6, 2022
@jgespino jgespino added category: MO Model Optimizer feature New feature request labels Jun 6, 2022
@jgespino
Copy link
Contributor

jgespino commented Jun 6, 2022

@lminer Could you share a model where these operations are being used and it's use case?

@lminer
Copy link
Author

lminer commented Jun 6, 2022

The use case is that the model is acting on audio data, which has been transformed into a complex spectrogram via an STFT. Most ops don't work on complex tensors, so typically we deal with this by pulling out the real and imaginary parts (hence the need for Real and Imag) as real tensors. At the end of our pipeline after we've sent the inputs through the network, we need to convert the output back into a complex tensor so that we can run an inverse-STFT. For this we need the Complex op.

I'd rather not share the model unless it's absolutely necessary, as it is proprietary...

@jgespino
Copy link
Contributor

jgespino commented Jun 8, 2022

@lminer Having the model would help the development team further understand the use case and what is needed to support such model. If you could share your model or a piece of the model where such layers are used. Feel free to send it via email (available on my profile), I may need additional information from you but I will ask privately if that's okay.

@lminer
Copy link
Author

lminer commented Jun 10, 2022

@jgespino just sent you a link to the model.

@jgespino
Copy link
Contributor

@lminer I don't see anything in my inbox, could you please check?

@lminer
Copy link
Author

lminer commented Jun 13, 2022

Weird. Just sent it again, this time from my gmail account.

@jgespino jgespino added the PSE label Jun 21, 2022
@jgespino
Copy link
Contributor

jgespino commented Jul 6, 2022

@lminer Thanks for sending the information via email. I have opened a request with the development team. I will provide any updates here as they are made available.

Ref. 87291

@jgespino jgespino removed their assignment Nov 7, 2022
@ilya-lavrenov ilya-lavrenov added the category: TF FE OpenVINO TensorFlow FrontEnd label Mar 1, 2023
@hbalasu1
Copy link
Contributor

hbalasu1 commented Apr 5, 2023

Hi @lminer, do you still need this feature request?

@hbalasu1 hbalasu1 self-assigned this Apr 5, 2023
@lminer
Copy link
Author

lminer commented Apr 5, 2023 via email

@mlukasze
Copy link
Contributor

mlukasze commented Apr 6, 2023

@hbalasu1 - internal ref nb: 98184

@lminer thanks for request, let us take it from here.

@akladiev
Copy link
Collaborator

This issue will be closed in 2 weeks in case of no activity.

@akladiev akladiev added the Stale label May 11, 2023
@avitial
Copy link
Contributor

avitial commented May 17, 2023

Please don't close.

@rkazants
Copy link
Contributor

Please don't close.

Agree

@devangaggarwal
Copy link

@lminer, @avitial we are actively looking into this issue. We will keep this thread updated as to when we have support for these ops.

@rkazants rkazants moved this to Contributors Needed in OpenVINO General Board Oct 21, 2023
@rkazants rkazants moved this from Contributors Needed to Assigned in OpenVINO General Board Oct 21, 2023
@rkazants rkazants changed the title [Feature Request] Support for complex tensorflow ops [Feature Request][TF FE] Support for complex tensorflow ops Oct 21, 2023
@rkazants
Copy link
Contributor

rkazants commented Nov 3, 2023

Hi @lminer,

We started to provide the preliminary support for complex tensors: #20860.
It would be great if you try it on your model.

Best regards,
Roman

@andrei-kochin
Copy link
Contributor

@lminer do you have any good news for us?

@lminer
Copy link
Author

lminer commented Nov 20, 2023

Unfortunately, we ended up changing our models so that they don't use complex tensors, so this would be tough to test now. We may switch them back though, going forward, depending on stft/complex tensor support.

@rkazants
Copy link
Contributor

Complex tensor support were implemented in PRs: #20860, #21498, #21477.

Please re-open this in case of concerns.

Best regards,
Roman

@rkazants rkazants moved this from Assigned to Closed in OpenVINO General Board Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer category: TF FE OpenVINO TensorFlow FrontEnd feature New feature request PSE
Projects
Development

No branches or pull requests