Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference engine should system pugixml if available #109

Closed
tripzero opened this issue Mar 27, 2019 · 6 comments · Fixed by #2502
Closed

inference engine should system pugixml if available #109

tripzero opened this issue Mar 27, 2019 · 6 comments · Fixed by #2502
Labels
bug Something isn't working category: inference OpenVINO Runtime library - Inference

Comments

@tripzero
Copy link

https://github.com/opencv/dldt/blob/2018/inference-engine/thirdparty/CMakeLists.txt#L10

@shubha-ramani
Copy link

Dear tripzero, I don't understand your comment. Can you kindly clarify it ?

Thanks,

Shubha

@alalek
Copy link

alalek commented Mar 27, 2019

  • buld/install
  • feature

Prefer using of system library (for example, installed via apt-get with "-dev" packages) instead of bundled 3rdparty code.

@tripzero
Copy link
Author

alalek is correct.

@tripzero
Copy link
Author

Any update on this? I had to disable the "add_subdir(pugixml)" line in inference-engine/thirdparty/CMakeLists.txt to avoid getting multiple cmake files that reference/depend on different versions of pugixml. The InferenceEngine-*Debug.cmake referenced 1.0.7 while the system had a newer version installed. The result was I couldn't build opencv with the InferenceEngine backend because pugixml 1.0.7 didn't exist on the system.

find_package is your friend.

@tripzero
Copy link
Author

I would argue this is NOT a feature request, but a bug. The result without this change is a broken dldt system (or elsewhere in compute stack) that may compile against or run against a different version than is intended. Without the "hack" I did to fix this, I had runtime errors.

@ilyachur ilyachur added category: inference OpenVINO Runtime library - Inference bug Something isn't working labels May 27, 2020
@ilyachur
Copy link
Contributor

We have a PR: #2502

This PR allows to use system pugixml.

@ilya-lavrenov ilya-lavrenov linked a pull request Oct 12, 2020 that will close this issue
eshoguli pushed a commit to eshoguli/openvino that referenced this issue Jun 1, 2021
riverlijunjie added a commit to riverlijunjie/openvino-1 that referenced this issue May 17, 2022
…pi_ppp

Finished OV 2.0 C-APIs PPP related development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: inference OpenVINO Runtime library - Inference
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants