Skip to content

Commit

Permalink
Fixed extensions (tokenizers) loading on Android (#26437)
Browse files Browse the repository at this point in the history
### Details:
- Android 's clang has issues with RTTI. So, we need to expose virtual
methods from the class to ensure dynamic cast is working.
  • Loading branch information
ilya-lavrenov authored Sep 5, 2024
1 parent c3152d3 commit e320367
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 1 addition & 3 deletions src/core/dev_api/openvino/core/so_extension.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ namespace detail {

class OPENVINO_API SOExtension : public Extension {
public:
~SOExtension() {
m_ext = {};
}
virtual ~SOExtension() override;

SOExtension(const Extension::Ptr& ext, const std::shared_ptr<void>& so) : m_ext(ext), m_so(so) {}

Expand Down
2 changes: 1 addition & 1 deletion src/core/include/openvino/core/op_extension.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class OPENVINO_API BaseOpExtension : public Extension {
/**
* @brief Destructor
*/
~BaseOpExtension() override;
virtual ~BaseOpExtension() override;
};

namespace detail {
Expand Down
4 changes: 4 additions & 0 deletions src/core/src/so_extension.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

#include "openvino/core/so_extension.hpp"

ov::detail::SOExtension::~SOExtension() {
m_ext.reset();
}

const ov::Extension::Ptr& ov::detail::SOExtension::extension() const {
return m_ext;
}
Expand Down

0 comments on commit e320367

Please sign in to comment.