Skip to content

Commit

Permalink
fix after code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mbencer committed Jul 29, 2020
1 parent b26330b commit 8170cec
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 12 deletions.
9 changes: 5 additions & 4 deletions ngraph/src/ngraph/op/binary_convolution.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,11 @@ void op::v1::BinaryConvolution::validate_and_infer_types()
{
result_shape[0] = data_batch_shape[0]; // batch size
}
}
if (filters_shape.rank().is_static() && filters_shape.rank().get_length() > 1)
{
result_shape[1] = filters_shape[0]; // filter channel size

if (filters_shape.rank().is_static() && filters_shape.rank().get_length() > 1)
{
result_shape[1] = filters_shape[0]; // filter channel size
}
}

if (m_strides.size() == 0)
Expand Down
9 changes: 5 additions & 4 deletions ngraph/src/ngraph/op/convolution.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,11 @@ void op::v1::Convolution::validate_and_infer_types()
{
result_shape[0] = data_batch_shape[0]; // batch size
}
}
if (filters_shape.rank().is_static() && filters_shape.rank().get_length() > 1)
{
result_shape[1] = filters_shape[0]; // filter channel size

if (filters_shape.rank().is_static() && filters_shape.rank().get_length() > 1)
{
result_shape[1] = filters_shape[0]; // filter channel size
}
}

element::Type result_et;
Expand Down
9 changes: 5 additions & 4 deletions ngraph/src/ngraph/op/deformable_convolution.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,11 @@ void op::v1::DeformableConvolution::validate_and_infer_types()
{
result_shape[0] = data_batch_shape[0]; // batch size
}
}
if (filters_shape.rank().is_static() && filters_shape.rank().get_length() > 1)
{
result_shape[1] = filters_shape[0]; // filter channel size

if (filters_shape.rank().is_static() && filters_shape.rank().get_length() > 1)
{
result_shape[1] = filters_shape[0]; // filter channel size
}
}

if (m_strides.size() == 0)
Expand Down

0 comments on commit 8170cec

Please sign in to comment.