Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to throw exception in case of empty chat template in chat scenario #697

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

olpipi
Copy link
Collaborator

@olpipi olpipi commented Jul 29, 2024

No description provided.

@olpipi olpipi requested review from Wovchena and pavel-esir and removed request for Wovchena July 29, 2024 09:07
@olpipi
Copy link
Collaborator Author

olpipi commented Jul 29, 2024

Do we really need test for this?

@Wovchena Wovchena linked an issue Jul 29, 2024 that may be closed by this pull request
src/cpp/src/llm_pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/llm_pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/tokenizer.cpp Outdated Show resolved Hide resolved
src/cpp/src/tokenizer.cpp Show resolved Hide resolved
@olpipi olpipi force-pushed the throw_empty_chat_template branch from f6386a9 to bf4f9f3 Compare July 29, 2024 16:34
@olpipi olpipi requested a review from Wovchena July 29, 2024 17:38
samples/cpp/chat_sample/README.md Outdated Show resolved Hide resolved
samples/python/chat_sample/README.md Outdated Show resolved Hide resolved
@olpipi olpipi requested a review from Wovchena July 30, 2024 15:06
@Wovchena Wovchena added this pull request to the merge queue Jul 30, 2024
Merged via the queue into openvinotoolkit:master with commit 4228131 Jul 30, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat streaming is not working with Phi 2
2 participants