Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ CB ] Return only N results from read_all #678

Merged
merged 5 commits into from
Nov 8, 2024
Merged

[ CB ] Return only N results from read_all #678

merged 5 commits into from
Nov 8, 2024

Conversation

iefode
Copy link
Contributor

@iefode iefode commented Jul 24, 2024 •
edited by andrei-kochin
Loading

CVS-146801

mzegla
mzegla reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@mzegla mzegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a python test for this?

src/cpp/src/generation_handle.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov self-assigned this Jul 31, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.4 milestone Aug 2, 2024
@ilya-lavrenov
Copy link
Contributor

@iefode please, finalize the PR.

@mzegla
Copy link
Collaborator

mzegla commented Aug 2, 2024

I suppose earlier we limited results in generate() method. With that change should we remove it from generate()?

@andrei-kochin andrei-kochin modified the milestones: 2024.4, 2024.5 Sep 9, 2024
@ilya-lavrenov ilya-lavrenov removed this from the 2024.5 milestone Oct 11, 2024
@github-actions github-actions bot added category: continuous batching Continuous batching category: sampling Sampling / Decoding algorithms labels Nov 5, 2024
@iefode iefode removed the category: sampling Sampling / Decoding algorithms label Nov 5, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Nov 5, 2024
@github-actions github-actions bot added the category: sampling Sampling / Decoding algorithms label Nov 7, 2024
@iefode iefode added this pull request to the merge queue Nov 8, 2024
Merged via the queue into openvinotoolkit:master with commit 72ce6de Nov 8, 2024
49 checks passed
@mzegla mzegla mentioned this pull request Nov 8, 2024
Merged
@iefode iefode deleted the correct_n_seq branch November 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzegla mzegla mzegla left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@Wovchena Wovchena Awaiting requested review from Wovchena

@dtrawins dtrawins Awaiting requested review from dtrawins

@popovaan popovaan Awaiting requested review from popovaan

Assignees

@ilya-lavrenov ilya-lavrenov

@mzegla mzegla

Labels
category: continuous batching Continuous batching category: sampling Sampling / Decoding algorithms
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
5 participants
@iefode @ilya-lavrenov @mzegla @Wovchena @andrei-kochin