Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Continuous batching] Replace standard max_element call with custom loop for greedy sampling #607

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

mzegla
Copy link
Collaborator

@mzegla mzegla commented Jul 11, 2024

Searching for max element in a custom loop gives better performance than using std::max_element

@mzegla mzegla requested review from Wovchena, iefode and popovaan July 11, 2024 11:23
@mzegla mzegla force-pushed the custom_loop_greedy branch from bf75e98 to da65723 Compare July 11, 2024 12:17
src/cpp/src/sampler.hpp Outdated Show resolved Hide resolved
@mzegla mzegla force-pushed the custom_loop_greedy branch from da65723 to c1a9e24 Compare July 11, 2024 14:46
@Wovchena Wovchena enabled auto-merge July 11, 2024 14:50
@Wovchena Wovchena added this pull request to the merge queue Jul 11, 2024
Merged via the queue into openvinotoolkit:master with commit 740c914 Jul 11, 2024
30 checks passed
mzegla added a commit to mzegla/openvino.genai that referenced this pull request Jul 22, 2024
…oop for greedy sampling (openvinotoolkit#607)

Searching for max element in a custom loop gives better performance than
using std::max_element
andrei-kochin pushed a commit that referenced this pull request Jul 26, 2024
…oop for greedy sampling (#607)

Searching for max element in a custom loop gives better performance than
using std::max_element
@ilya-lavrenov ilya-lavrenov self-assigned this Jul 31, 2024
@mzegla mzegla deleted the custom_loop_greedy branch September 3, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants