[test] Ensure that the first token generation is not included into TPOT #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-esir
changed the title
github-actions
bot
added
category: LLM
pavel-esir
commented
Dec 19, 2024
| @@ -101,7 +101,7 @@ void PerfMetrics::evaluate_statistics(std::optional<TimePoint> start_time) { | |||
|
|
|||
| auto ttft = tok_times[0] - start_time_val; | |||
| raw_metrics.m_times_to_first_token = std::vector<MicroSeconds>(); | |||
| raw_metrics.m_times_to_first_token.emplace_back(ttft / batch_sizes[0]); | |||
| raw_metrics.m_times_to_first_token.emplace_back(ttft); | |||
There was a problem hiding this comment.
If we have batch 10 and it takes 1 sec until the first token is generated then time to the first token is still 1 sec not 100 ms! Therefore i removed / batch_sizes[0]
There was a problem hiding this comment.
I agree, but should we notify llm_bench about the change?
There was a problem hiding this comment.
I asked @eaidova what she thinks. Let's wait her answer
There was a problem hiding this comment.
@peterchen-intel @wgzintel do you have objections? What the reason to divide first token latency on batch?
There was a problem hiding this comment.
As i see from blame, this division was added by @ialbrecht. Do you have any objection to remove it?
Wovchena
approved these changes
Dec 20, 2024
eaidova
approved these changes
Dec 20, 2024
pavel-esir
force-pushed
the
improve_perf_tests
branch
from
a247803 to
a1e0d35
Compare
ilya-lavrenov
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVS-155098