Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch user passed chat template #1204

Conversation

ilya-lavrenov
Copy link
Contributor

External chat template is not patched for some reason, but it still can contain JinjaCpp unsupported constructions.

@ilya-lavrenov ilya-lavrenov added the bug Something isn't working label Nov 13, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Nov 13, 2024
@github-actions github-actions bot added category: sampling Sampling / Decoding algorithms category: tokenizers Tokenizer class or submodule update labels Nov 13, 2024
@ilya-lavrenov ilya-lavrenov force-pushed the tokenizer-custom-chat-template branch from 3c9b8f7 to 9d8be8e Compare November 13, 2024 07:34
@ilya-lavrenov ilya-lavrenov merged commit 164dc78 into openvinotoolkit:master Nov 13, 2024
46 of 52 checks passed
@ilya-lavrenov ilya-lavrenov deleted the tokenizer-custom-chat-template branch November 13, 2024 16:26
@ilya-lavrenov ilya-lavrenov added the port to LTS PR needs to be ported to LTS label Nov 13, 2024
ilya-lavrenov added a commit to ilya-lavrenov/openvino.genai that referenced this pull request Nov 20, 2024
External chat template is not patched for some reason, but it still can
contain JinjaCpp unsupported constructions.
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2024
@ilya-lavrenov ilya-lavrenov removed the port to LTS PR needs to be ported to LTS label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: sampling Sampling / Decoding algorithms category: tokenizers Tokenizer class or submodule update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants