Stubs files for genai bindings #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: text to image
| def __init__(self, models_path: str, scheduler_config: SchedulerConfig, device: str, properties: dict[str, typing.Any] = {}, tokenizer_properties: dict[str, typing.Any] = {}) -> None: | ||
| ... | ||
| @typing.overload | ||
| def __init__(self, models_path: str, tokenizer: Tokenizer, scheduler_config: SchedulerConfig, device: str, properties: dict[str, typing.Any] = {}) -> None: |
There was a problem hiding this comment.
properties are not aligned with other pipelines where we have kwargs.
Maybe we can drop tokenizer_properties (if they are not used anywhere) and use kwargs only
There was a problem hiding this comment.
I think tokenizer_properties are needed for OVMS to set throughput hint
github-actions
bot
added
the
category: GenAI C++ API
| from openvino_genai.py_openvino_genai import draft_model | ||
| import os as os | ||
| from . import py_openvino_genai | ||
| __all__ = ['Adapter', 'AdapterConfig', 'AggregationMode', 'AutoencoderKL', 'CLIPTextModel', 'CLIPTextModelWithProjection', 'CacheEvictionConfig', 'ChunkStreamerBase', 'ContinuousBatchingPipeline', 'CppStdGenerator', 'DecodedResults', 'EncodedResults', 'GenerationConfig', 'GenerationResult', 'Generator', 'ImageGenerationConfig', 'LLMPipeline', 'PerfMetrics', 'RawPerfMetrics', 'Scheduler', 'SchedulerConfig', 'StopCriteria', 'StreamerBase', 'Text2ImagePipeline', 'TokenizedInputs', 'Tokenizer', 'UNet2DConditionModel', 'VLMPipeline', 'WhisperGenerationConfig', 'WhisperPipeline', 'draft_model', 'openvino', 'os', 'py_openvino_genai'] |
There was a problem hiding this comment.
should we avoid providing 'os' ?
There was a problem hiding this comment.
Looks like it is bybind11-stubgen bug, mypy-stubgen doesn't export os.
Commited mypy-stubgen output for comparison: 1234257
There was a problem hiding this comment.
Looks like it's done because of os.PathLike
In general, it's not a problem as os is standard module. I think we can merge pybind11-stubgen output as start point.
Wovchena
approved these changes
Nov 12, 2024
ilya-lavrenov
approved these changes
Nov 12, 2024
Done. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ilya-lavrenov
pushed a commit
to ilya-lavrenov/openvino.genai
that referenced
this pull request
Dec 3, 2024
Merged
ilya-lavrenov
added a commit
that referenced
this pull request
Dec 4, 2024
- #1158 - #1178 - #1214 - #1243 - #1253 - #1259 - #1266 - #1271 - #1278 - #1280 - #1284 - e4a86f6 - #1246 - #958 --------- Co-authored-by: Anastasiia Pnevskaia <[email protected]> Co-authored-by: Helena Kloosterman <[email protected]> Co-authored-by: Vladimir Zlobin <[email protected]> Co-authored-by: Dmitry Matveev <[email protected]> Co-authored-by: Anna Likholat <[email protected]> Co-authored-by: Alina Kladieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVS-156607