Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] nncf/data #3173

Merged
merged 7 commits into from
Jan 8, 2025
Merged

[mypy] nncf/data #3173

merged 7 commits into from
Jan 8, 2025

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Jan 2, 2025 •
edited
Loading

Changes

Enable mypy check for nncf/data
Removed Generic[DataItem, ModelInput] for nncf.Dataset, to simplify using class

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner January 2, 2025 13:00
@github-actions github-actions bot added the API Public API-impacting changes label Jan 2, 2025
alexsu52
alexsu52 requested changes Jan 6, 2025
View reviewed changes
nncf/data/dataset.py Outdated Show resolved Hide resolved
nncf/data/dataset.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the API Public API-impacting changes label Jan 6, 2025
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as draft January 7, 2025 12:07
@github-actions github-actions bot added NNCF Common Pull request that updates NNCF Common API Public API-impacting changes labels Jan 7, 2025
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review January 7, 2025 14:02
andrey-churkin
andrey-churkin approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@andrey-churkin andrey-churkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nncf/data/dataset.py Outdated Show resolved Hide resolved
alexsu52
alexsu52 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderDokuchaev AlexanderDokuchaev merged commit f37e5ad into openvinotoolkit:develop Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-churkin andrey-churkin andrey-churkin approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderDokuchaev @alexsu52 @andrey-churkin