Add fail_if_symlink to fns.io functions #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderDokuchaev
approved these changes
Dec 16, 2024
kshpv
added a commit
to kshpv/nncf
that referenced
this pull request
Dec 16, 2024
### Changes - Add `fail_if_symlink` check to check symbolic links before load statistics files - Remove try block for `fns.io.save_file` in dump_statistics ### Reason for changes Prevent problems with symlinks --------- Co-authored-by: Alexander Dokuchaev <[email protected]>
KodiaqQ
pushed a commit
that referenced
this pull request
Dec 17, 2024
#3150 Co-authored-by: Alexander Dokuchaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fail_if_symlinkcheck to check symbolic links before load statistics filesfns.io.save_filein dump_statisticsReason for changes
Prevent problems with symlinks