-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MinMax] Move get_statistic_collector from backend to common #3132
[MinMax] Move get_statistic_collector from backend to common #3132
Conversation
Hi @daniil-lyakhov, Can you run the checks and review the changes made so far in this PR? The min_max tests do not require any updates so far from what I have observed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Couple comments from my side:
Co-authored-by: Daniil Lyakhov <[email protected]>
Co-authored-by: Daniil Lyakhov <[email protected]>
Co-authored-by: Daniil Lyakhov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@AlexanderDokuchaev, please review and merge if you have no comments |
@rk119 Well done |
Changes
REDUCERS_MAP
innncf/experimental/common/tensor_statistics/collectors.py
for backends PT, FX and ONNX.get_statistic_collector
method in the commonnncf/quantization/algorithms/min_max/algorithm.py
file and defined areducers_map
property to each backend file.inplace_statistics
to False innncf/quantization/advanced_parameters.py
since the attributeinplace
inget_statistic_collector
innncf/quantization/algorithms/min_max/algorithm.py
is now passed for all backends, it needs to be False by default and True only for OpenVino.get_statistic_collector
method definition from PT, FX, ONNX and OpenVinomin_max
backend specific files.get_statistic_collector
method frommin_max/backend.py
as it is no longer needed.Reason for changes
To remove redundant method definitions in all backends.
Related tickets
#3120