Collect statistics from subset in weight compression #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
NNCF OpenVINO
ljaljushkin
force-pushed
the
nl/fix_subset_size
branch
from
148a751 to
bb51646
Compare
andreyanufr
approved these changes
Nov 7, 2024
Comment on lines
759
to
762
| model: TModel, | ||
| graph: NNCFGraph, | ||
| nodes_and_port_ids: Iterable[Tuple[NNCFNode, int]], | ||
| subset_size: Optional[int] = None, | ||
| ) -> StatisticPointsContainer: |
There was a problem hiding this comment.
What do you think about also removing subset_size parameter from MixedPrecisionCriterion.get_statistic_points() method for two algorithms to be more aligned? I believe subset_size can be provided to criterion constructor similarly as it is done for WeightCompression algorithm.
There was a problem hiding this comment.
Had to make it optional for data-free mixed precision, but probably it's better since the parameter is passed only once.
nikita-savelyevv
approved these changes
Nov 7, 2024
kshpv
approved these changes
Nov 7, 2024
nikita-savelyevv
pushed a commit
to nikita-savelyevv/nncf
that referenced
this pull request
Dec 11, 2024
…#3061) ### Changes Set a subset size for collecting statistics ### Reason for changes `subset size` option is ignored and the whole dataset is used ### Related tickets n/a ### Tests - [x] unit test for setting subset size - [x] manual/job/post_training_weight_compression/245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set a subset size for collecting statistics
Reason for changes
subset sizeoption is ignored and the whole dataset is usedRelated tickets
n/a
Tests